jyapayne/Nim
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

remove un-needed {.push hint[ConvFromXtoItselfNotNeeded]: off.} in asyncfutures, asyncmacro (#17631)

Browse source
This commit is contained in:
Timothee Cour 2021-04-03 15:24:01 -07:00 • committed by GitHub
commit 97764c8dc9
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
2 changed files with 1 additions and 6 deletions
Download patch file Download diff file Expand all files Collapse all files

2
lib/pure/asyncfutures.nim
View file

@ -363,12 +363,10 @@ proc read*[T](future: Future[T] | FutureVar[T]): T =
## this function will fail with a `ValueError` exception.
##
## If the result of the future is an error then that error will be raised.
{.push hint[ConvFromXtoItselfNotNeeded]: off.}
when future is Future[T]:
let fut = future
else:
let fut = Future[T](future)
{.pop.}
if fut.finished:
if fut.error != nil:
injectStacktrace(fut)

5
lib/pure/asyncmacro.nim
View file

@ -35,14 +35,11 @@ template createCb(retFutureSym, iteratorNameSym,
if next == nil:
if not retFutureSym.finished:
let msg = "Async procedure ($1) yielded `nil`, are you await'ing a " &
"`nil` Future?"
let msg = "Async procedure ($1) yielded `nil`, are you await'ing a `nil` Future?"
raise newException(AssertionDefect, msg % strName)
else:
{.gcsafe.}:
{.push hint[ConvFromXtoItselfNotNeeded]: off.}
next.addCallback cast[proc() {.closure, gcsafe.}](identName)
{.pop.}
except:
futureVarCompletions
if retFutureSym.finished: