jyapayne/Nim
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

fixed system.delete (#18507)

Browse source
This commit is contained in:
Andreas Rumpf 2021-07-18 15:16:26 +02:00 • committed by GitHub
commit 99c4b69097
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
3 changed files with 26 additions and 12 deletions
Download patch file Download diff file Expand all files Collapse all files

17
lib/system.nim
View file

@ -2134,7 +2134,12 @@ const
import system/dollars
export dollars
proc delete*[T](x: var seq[T], i: Natural) {.noSideEffect.} =
when defined(nimAuditDelete):
{.pragma: auditDelete, deprecated: "review this call for out of bounds behavior".}
else:
{.pragma: auditDelete.}
proc delete*[T](x: var seq[T], i: Natural) {.noSideEffect, auditDelete.} =
## Deletes the item at index `i` by moving all `x[i+1..^1]` items by one position.
##
## This is an `O(n)` operation.
@ -2147,12 +2152,10 @@ proc delete*[T](x: var seq[T], i: Natural) {.noSideEffect.} =
s.delete(2)
doAssert s == @[1, 2, 4, 5]
doAssertRaises(IndexDefect):
s.delete(4)
if i > high(x):
# xxx this should call `raiseIndexError2(i, high(x))` after some refactoring
raise (ref IndexDefect)(msg: "index out of bounds: '" & $i & "' < '" & $x.len & "' failed")
when defined(nimStrictDelete):
if i > high(x):
# xxx this should call `raiseIndexError2(i, high(x))` after some refactoring
raise (ref IndexDefect)(msg: "index out of bounds: '" & $i & "' < '" & $x.len & "' failed")
template defaultImpl =
let xl = x.len