clean up old codes (#16284)

* clean up old codes

* fix docs and links

* clean

compiler/condsyms.nim

@@ -58,7 +58,6 @@ proc initDefines*(symbols: StringTableRef) =
   defineSymbol("nimGenericInOutFlags")
   when false: defineSymbol("nimHasOpt")
   defineSymbol("nimNoArrayToCstringConversion")
-  defineSymbol("nimNewRoof")
   defineSymbol("nimHasRunnableExamples")
   defineSymbol("nimNewDot")
   defineSymbol("nimHasNilChecks")

lib/system/iterators_1.nim

@@ -9,15 +9,20 @@ iterator countdown*[T](a, b: T, step: Positive = 1): T {.inline.} =
   ##
   ## `T` may be any ordinal type, `step` may only be positive.
   ##
-  ## **Note**: This fails to count to ``low(int)`` if T = int for
+  ## **Note**: This fails to count to `low(int)` if T = int for
   ## efficiency reasons.
-  ##
+  runnableExamples:
-  ## .. code-block:: Nim
+    import sugar
-  ##   for i in countdown(7, 3):
+    let x = collect(newSeq):
-  ##     echo i # => 7; 6; 5; 4; 3
+      for i in countdown(7, 3):
-  ##
+        i
-  ##   for i in countdown(9, 2, 3):
+    
-  ##     echo i # => 9; 6; 3
+    assert x == @[7, 6, 5, 4, 3]
+
+    let y = collect(newseq):
+      for i in countdown(9, 2, 3):
+        i
+    assert y == @[9, 6, 3]
   when T is (uint|uint64):
     var res = a
     while res >= b:
@@ -35,22 +40,26 @@ iterator countdown*[T](a, b: T, step: Positive = 1): T {.inline.} =
       yield res
       dec(res, step)
 
-when defined(nimNewRoof):
 iterator countup*[T](a, b: T, step: Positive = 1): T {.inline.} =
   ## Counts from ordinal value `a` to `b` (inclusive) with the given
   ## step count.
   ##
   ## `T` may be any ordinal type, `step` may only be positive.
   ##
-    ## **Note**: This fails to count to ``high(int)`` if T = int for
+  ## **Note**: This fails to count to `high(int)` if T = int for
   ## efficiency reasons.
-    ##
+  runnableExamples:
-    ## .. code-block:: Nim
+    import sugar
-    ##   for i in countup(3, 7):
+    let x = collect(newSeq):
-    ##     echo i # => 3; 4; 5; 6; 7
+      for i in countup(3, 7):
-    ##
+        i
-    ##   for i in countup(2, 9, 3):
+    
-    ##     echo i # => 2; 5; 8
+    assert x == @[3, 4, 5, 6, 7]
+
+    let y = collect(newseq):
+      for i in countup(2, 9, 3):
+        i
+    assert y == @[2, 5, 8]
   mixin inc
   when T is IntLikeForCount and T is Ordinal:
     var res = int(a)
@@ -68,10 +77,14 @@ when defined(nimNewRoof):
   ##
   ## See also:
   ## * [..<](#..<.i,T,T)
-    ##
+  runnableExamples:
-    ## .. code-block:: Nim
+    import sugar
-    ##   for i in 3 .. 7:
+
-    ##     echo i # => 3; 4; 5; 6; 7
+    let x = collect(newSeq):
+      for i in 3 .. 7:
+        i
+
+    assert x == @[3, 4, 5, 6, 7]
   mixin inc
   when T is IntLikeForCount and T is Ordinal:
     var res = int(a)
@@ -86,7 +99,7 @@ when defined(nimNewRoof):
 
 template dotdotImpl(t) {.dirty.} =
   iterator `..`*(a, b: t): t {.inline.} =
-      ## A type specialized version of ``..`` for convenience so that
+    ## A type specialized version of `..` for convenience so that
     ## mixing integer types works better.
     ##
     ## See also:
@@ -110,7 +123,7 @@ when defined(nimNewRoof):
 
 template dotdotLessImpl(t) {.dirty.} =
   iterator `..<`*(a, b: t): t {.inline.} =
-      ## A type specialized version of ``..<`` for convenience so that
+    ## A type specialized version of `..<` for convenience so that
     ## mixing integer types works better.
     var res = a
     while res < b:
@@ -122,62 +135,6 @@ when defined(nimNewRoof):
 dotdotLessImpl(uint64)
 dotdotLessImpl(uint32)
 
-else: # not defined(nimNewRoof)
-  iterator countup*[S, T](a: S, b: T, step = 1): T {.inline.} =
-    ## Counts from ordinal value `a` up to `b` (inclusive) with the given
-    ## step count.
-    ##
-    ## `S`, `T` may be any ordinal type, `step` may only be positive.
-    ##
-    ## **Note**: This fails to count to ``high(int)`` if T = int for
-    ## efficiency reasons.
-    ##
-    ## .. code-block:: Nim
-    ##   for i in countup(3, 7):
-    ##     echo i # => 3; 4; 5; 6; 7
-    ##
-    ##   for i in countup(2, 9, 3):
-    ##     echo i # => 2; 5; 8
-    when T is IntLikeForCount and T is Ordinal:
-      var res = int(a)
-      while res <= int(b):
-        yield T(res)
-        inc(res, step)
-    else:
-      var res = T(a)
-      while res <= b:
-        yield res
-        inc(res, step)
-
-  iterator `..`*[S, T](a: S, b: T): T {.inline.} =
-    ## An alias for `countup(a, b, 1)`.
-    ##
-    ## See also:
-    ## * [..<](#..<.i,T,T)
-    ##
-    ## .. code-block:: Nim
-    ##   for i in 3 .. 7:
-    ##     echo i # => 3; 4; 5; 6; 7
-    mixin inc
-    when T is IntLikeForCount and T is Ordinal:
-      var res = int(a)
-      while res <= int(b):
-        yield T(res)
-        inc(res)
-    else:
-      var res = T(a)
-      while res <= b:
-        yield res
-        inc(res)
-
-  iterator `..<`*[S, T](a: S, b: T): T {.inline.} =
-    mixin inc
-    var i = T(a)
-    while i < b:
-      yield i
-      inc i
-
-
 iterator `||`*[S, T](a: S, b: T, annotation: static string = "parallel for"): T {.
   inline, magic: "OmpParFor", sideEffect.} =
   ## OpenMP parallel loop iterator. Same as `..` but the loop may run in parallel.
@@ -189,9 +146,9 @@ iterator `||`*[S, T](a: S, b: T, annotation: static string = "parallel for"): T
   ## for further information.
   ##
   ## Note that the compiler maps that to
-  ## the ``#pragma omp parallel for`` construct of `OpenMP`:idx: and as
+  ## the `#pragma omp parallel for` construct of `OpenMP`:idx: and as
   ## such isn't aware of the parallelism in your code! Be careful! Later
-  ## versions of ``||`` will get proper support by Nim's code generator
+  ## versions of `||` will get proper support by Nim's code generator
   ## and GC.
   discard
 
@@ -207,8 +164,8 @@ iterator `||`*[S, T](a: S, b: T, step: Positive, annotation: static string = "pa
   ## for further information.
   ##
   ## Note that the compiler maps that to
-  ## the ``#pragma omp parallel for`` construct of `OpenMP`:idx: and as
+  ## the `#pragma omp parallel for` construct of `OpenMP`:idx: and as
   ## such isn't aware of the parallelism in your code! Be careful! Later
-  ## versions of ``||`` will get proper support by Nim's code generator
+  ## versions of `||` will get proper support by Nim's code generator
   ## and GC.
   discard