jyapayne/Nim
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

fix https://github.com/timotheecour/Nim/issues/152: avoid writing spurious ^[[0m to stderr when callStyledWriteLineStderr not called (#14214)

Browse source 
* fix https://github.com/timotheecour/Nim/issues/152 `^[[0m` is inserted in stderr for `echo code | nim c -`

* resetAttributes not even needed, already handled in styledWriteLine

* simplify tests in tests/trunner.nim thanks to this fix
This commit is contained in:
Timothee Cour 2020-05-04 06:07:32 -07:00 • committed by GitHub
commit a23302ef56
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
3 changed files with 5 additions and 12 deletions
Download patch file Download diff file Expand all files Collapse all files

8
tests/trunner.nim
View file

@ -74,9 +74,7 @@ else: # don't run twice the same test
var output = p.outputStream.readAll
let error = p.errorStream.readAll
doAssert p.waitForExit == 0
when false: # https://github.com/timotheecour/Nim/issues/152
# bug: `^[[0m` is being inserted somehow with `-` (regarless of --run)
doAssert error.len == 0, $(error,)
doAssert error.len == 0, $error
output.stripLineEnd
doAssert output == expected
p.errorStream.close
@ -85,8 +83,6 @@ else: # don't run twice the same test
block:
when defined(posix):
let cmd = fmt"echo 'import os; echo commandLineParams()' | {nimcmd}"
# avoid https://github.com/timotheecour/Nim/issues/152 by
# making sure `poStdErrToStdOut` isn't passed
var (output, exitCode) = execCmdEx(cmd, options = {poEvalCommand})
var (output, exitCode) = execCmdEx(cmd)
output.stripLineEnd
doAssert output == expected