make nimble packages testing more robust (#10984)

* better tests for the existing packages
* enable testing for packages not in packages.json
* add new packages

testament/categories.nim

@@ -470,18 +470,25 @@ proc getPackageDir(package: string): string =
 iterator listPackages(): tuple[name, url, cmd: string, hasDeps: bool] =
   let defaultCmd = "nimble test"
   let packageList = parseFile(packageIndex)
-  for n, cmd, commit, hasDeps in important_packages.packages.items:
+  for n, cmd, hasDeps, url in important_packages.packages.items:
-    var found = false
+    let cmd = if cmd.len == 0: defaultCmd else: cmd
-    for package in packageList.items:
+    if url.len != 0:
-      let name = package["name"].str
+      if hasDeps:
-      if name == n:
+        # use url instead of name, so we can do 'nimble install'
-        found = true
+        yield (url, url, cmd, hasDeps)
-        let url = package["url"].str
+      else:
-        let cmd = if cmd.len == 0: defaultCmd else: cmd
+        yield (n, url, cmd, hasDeps)
-        yield (name, url, cmd, hasDeps)
+    else:
-        break
+      var found = false
-    if not found:
+      for package in packageList.items:
-      raise newException(ValueError, "Cannot find package '$#'." % n)
+        let name = package["name"].str
+        if name == n:
+          found = true
+          let p_url = package["url"].str
+          yield (name, p_url, cmd, hasDeps)
+          break
+      if not found:
+        raise newException(ValueError, "Cannot find package '$#'." % n)
 
 proc makeSupTest(test, options: string, cat: Category): TTest =
   result.cat = cat

testament/important_packages.nim

@@ -1,50 +1,78 @@
 import strutils
 
-template pkg(name: string; cmd = "nimble test"; version = ""; hasDeps = false): untyped =
+template pkg(name: string; cmd = "nimble test"; hasDeps = false; url = ""): untyped =
-  packages.add((name, cmd, version, hasDeps))
+  packages.add((name, cmd, hasDeps, url))
 
-var packages*: seq[tuple[name, cmd, version: string; hasDeps: bool]] = @[]
+var packages*: seq[tuple[name, cmd: string; hasDeps: bool; url: string]] = @[]
 
 
-pkg "arraymancer", "nim c src/arraymancer.nim", "", true
+pkg "argparse"
-pkg "ast_pattern_matching", "nim c tests/test1.nim"
+pkg "arraymancer", "nim c -r src/arraymancer.nim", true
-pkg "blscurve", "", "", true
+pkg "ast_pattern_matching", "nim c -r tests/test1.nim"
-pkg "bncurve", "nim c tests/tarith.nim", "", true
+pkg "binaryheap", "nim c -r binaryheap.nim"
+pkg "blscurve", "", true
+pkg "bncurve", "", true
 pkg "c2nim", "nim c testsuite/tester.nim"
-pkg "chronicles", "nim c -o:chr chronicles.nim", "", true
+pkg "cascade"
-# pkg "chronos", "nim c tests/teststream.nim"
+pkg "chroma"
-pkg "cligen", "nim c -o:cligenn cligen.nim"
+pkg "chronicles", "nim c -o:chr -r chronicles.nim", true
-pkg "compactdict", "nim c tests/test1.nim"
+pkg "chronos"
+pkg "cligen", "nim c -o:cligenn -r cligen.nim"
+pkg "combparser"
+pkg "compactdict"
+pkg "comprehension", "", false, "https://github.com/alehander42/comprehension"
 pkg "criterion"
+pkg "dashing", "nim c tests/functional.nim"
 pkg "docopt"
-pkg "gara", "nim c tests/test_gara.nim"
+pkg "fragments", "nim c -r fragments/dsl.nim"
+pkg "gara"
 pkg "glob"
 pkg "gnuplot"
-pkg "hts", "nim c tests/all.nim"
+# pkg "godot", "nim c -r godot/godot.nim" # not yet compatible with Nim 0.19
+pkg "hts", "nim c -o:htss -r src/hts.nim"
 pkg "inim"
 pkg "itertools", "nim doc src/itertools.nim"
 pkg "iterutils"
-pkg "karax", "nim c tests/tester.nim"
+pkg "jstin"
+pkg "karax", "nim c -r tests/tester.nim"
 pkg "loopfusion"
+pkg "msgpack4nim"
 pkg "nake", "nim c nakefile.nim"
-pkg "neo", "nim c -d:blas=openblas tests/all.nim", "", true
+pkg "neo", "nim c -d:blas=openblas tests/all.nim", true
-pkg "nigui", "nim c -o:niguii src/nigui.nim"
+# pkg "nico", "", true
-pkg "nimcrypto", "nim c tests/testapi.nim"
+pkg "nicy", "nim c src/nicy.nim"
-pkg "NimData", "nim c -o:nimdataa src/nimdata.nim", "", true
+pkg "nigui", "nim c -o:niguii -r src/nigui.nim"
-pkg "nimes", "nim c src/nimes.nim", "", true
+pkg "nimcrypto", "nim c -r tests/testapi.nim"
-pkg "nimgame2", "nim c nimgame2/nimgame.nim", "", true
+pkg "NimData", "nim c -o:nimdataa src/nimdata.nim", true
-pkg "nimongo", "nimble test_ci", "", true
+pkg "nimes", "nim c src/nimes.nim", true
-pkg "nimpy", "nim c tests/nimfrompy.nim"
+pkg "nimfp", "nim c -o:nfp -r src/fp.nim", true
-pkg "nimsl", "nim c test.nim"
+pkg "nimgame2", "nim c nimgame2/nimgame.nim", true
+pkg "nimgen", "nim c -o:nimgenn -r src/nimgen/runcfg.nim", true
+# pkg "nimlsp", "", true
+pkg "nimly", "nim c -r tests/test_nimly", true
+pkg "nimongo", "nimble test_ci", true
+pkg "nimpy", "nim c -r tests/nimfrompy.nim"
+pkg "nimquery"
+pkg "nimsl", "", true
 pkg "nimsvg"
-# pkg "nimx", "nim c --threads:on test/main.nim", "", true
+pkg "nimx", "nim c --threads:on test/main.nim", true
+pkg "norm", "nim c -o:normm src/norm.nim"
+pkg "npeg"
+pkg "ormin", "nim c -o:orminn ormin.nim", true
 pkg "parsetoml"
 pkg "patty"
-pkg "plotly", "nim c examples/all.nim", "", true
+pkg "plotly", "nim c examples/all.nim", true
-pkg "protobuf", "nim c -o:protobuff src/protobuf.nim", "", true
+pkg "protobuf", "nim c -o:protobuff -r src/protobuf.nim", true
-pkg "regex", "nim c src/regex"
+pkg "regex", "nim c src/regex", true
-pkg "rosencrantz", "nim c -o:rsncntz rosencrantz.nim"
+pkg "result", "nim c -r result.nim"
-pkg "sdl1", "nim c src/sdl.nim"
+pkg "rosencrantz", "nim c -o:rsncntz -r rosencrantz.nim"
-pkg "sdl2_nim", "nim c sdl2/sdl.nim"
+pkg "sdl1", "nim c -r src/sdl.nim"
-pkg "stint", "nim c -o:stintt stint.nim"
+pkg "sdl2_nim", "nim c -r sdl2/sdl.nim"
-pkg "zero_functional", "nim c test.nim"
+pkg "stint", "nim c -o:stintt -r stint.nim"
+pkg "strunicode", "nim c -r src/strunicode.nim", true
+pkg "tiny_sqlite"
+pkg "unicodedb"
+pkg "unicodeplus", "", true
+pkg "unpack"
+pkg "yaml"
+pkg "zero_functional", "nim c -r test.nim"