jyapayne/Nim
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

refs #16338 make thttpclient_ssl_remotenetwork.nim less flaky (#17457)

Browse source
This commit is contained in:
Timothee Cour 2021-03-23 00:30:41 -07:00 • committed by GitHub
commit b50776dd2f
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
1 changed files with 14 additions and 3 deletions
Download patch file Download diff file Expand all files Collapse all files

17
tests/untestable/thttpclient_ssl_remotenetwork.nim
View file

@ -115,12 +115,23 @@ when enableRemoteNetworking and (defined(nimTestsEnableFlaky) or not defined(win
else: else:
# this is unexpected # this is unexpected
var fatal = true
var msg = ""
if raised: if raised:
echo " $# ($#) raised: $#" % [desc, $category, exception_msg] msg = " $# ($#) raised: $#" % [desc, $category, exception_msg]
if "500 Internal Server Error" in exception_msg:
# refs https://github.com/nim-lang/Nim/issues/16338#issuecomment-804300278
# we got: `good (good) raised: 500 Internal Server Error`
fatal = false
msg.add " (http 500 => assuming this is not our problem)"
else: else:
echo " $# ($#) did not raise" % [desc, $category] msg = " $# ($#) did not raise" % [desc, $category]
if category in {good, dubious, bad}:
if category in {good, dubious, bad} and fatal:
echo "D20210322T121353: error: " & msg
fail() fail()
else:
echo "D20210322T121353: warning: " & msg
suite "SSL certificate check - httpclient": suite "SSL certificate check - httpclient":