jyapayne/Nim
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Use addCallback rather than callback= in asyncfutures.all() (#6850)

Browse source 
* Use addCallback rather than callback= in asyncfutures.all()

Addresses part of #6849

* Stop using do notation for #6849

* Update example style
This commit is contained in:
Mathias Stearn 2017-12-08 19:55:04 -05:00 • committed by Dominik Picheta
commit b87ef65532
3 changed files with 22 additions and 4 deletions
Download patch file Download diff file Expand all files Collapse all files

4
lib/pure/asyncfutures.nim
View file

@ -333,7 +333,7 @@ proc all*[T](futs: varargs[Future[T]]): auto =
let totalFutures = len(futs)
for fut in futs:
fut.callback = proc(f: Future[T]) =
fut.addCallback proc (f: Future[T]) =
inc(completedFutures)
if not retFuture.finished:
if f.failed:
@ -355,7 +355,7 @@ proc all*[T](futs: varargs[Future[T]]): auto =
for i, fut in futs:
proc setCallback(i: int) =
fut.callback = proc(f: Future[T]) =
fut.addCallback proc (f: Future[T]) =
inc(completedFutures)
if not retFuture.finished:
if f.failed: