jyapayne/Nim
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

[std/tables] remove unnecessary do: (#18160)

Browse source
This commit is contained in:
flywind 2021-06-03 12:09:04 +08:00 • committed by GitHub
commit bbce3d2da9
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
1 changed files with 16 additions and 10 deletions
Download patch file Download diff file Expand all files Collapse all files

26
lib/pure/collections/tables.nim
View file

@ -594,17 +594,17 @@ template withValue*[A, B](t: var Table[A, B], key: A, value, body: untyped) =
let u = User(name: "Hello", uid: 99) let u = User(name: "Hello", uid: 99)
t[1] = u t[1] = u
t.withValue(1, value) do: t.withValue(1, value):
# block is executed only if `key` in `t` # block is executed only if `key` in `t`
value.name = "Nim" value.name = "Nim"
value.uid = 1314 value.uid = 1314
t.withValue(2, value) do: t.withValue(2, value):
value.name = "No" value.name = "No"
value.uid = 521 value.uid = 521
doAssert t[1].name == "Nim" assert t[1].name == "Nim"
doAssert t[1].uid == 1314 assert t[1].uid == 1314
mixin rawGet mixin rawGet
var hc: Hash var hc: Hash
@ -629,16 +629,22 @@ template withValue*[A, B](t: var Table[A, B], key: A,
let u = User(name: "Hello", uid: 99) let u = User(name: "Hello", uid: 99)
t[1] = u t[1] = u
t.withValue(1, value) do: t.withValue(1, value):
# block is executed only if `key` in `t` # block is executed only if `key` in `t`
value.name = "Nim" value.name = "Nim"
value.uid = 1314 value.uid = 1314
# do:
# # block is executed when `key` not in `t`
# raise newException(KeyError, "Key not found")
doAssert t[1].name == "Nim" t.withValue(521, value):
doAssert t[1].uid == 1314 doAssert false
do:
# block is executed when `key` not in `t`
t[1314] = User(name: "exist", uid: 521)
assert t[1].name == "Nim"
assert t[1].uid == 1314
assert t[1314].name == "exist"
assert t[1314].uid == 521
mixin rawGet mixin rawGet
var hc: Hash var hc: Hash
var index = rawGet(t, key, hc) var index = rawGet(t, key, hc)