jyapayne/Nim
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

produce more helpful error messages when overloading resolution fails

Browse source
This commit is contained in:
Andreas Rumpf 2018-11-03 15:56:13 +01:00
commit c739b9192f
4 changed files with 18 additions and 8 deletions
Download patch file Download diff file Expand all files Collapse all files

20
compiler/semcall.nim
View file

@ -166,20 +166,22 @@ proc presentFailedCandidates(c: PContext, n: PNode, errors: CandidateErrors):
prefer = preferModuleInfo
break
when false:
# we pretend procs are attached to the type of the first
# argument in order to remove plenty of candidates. This is
# comparable to what C# does and C# is doing fine.
var filterOnlyFirst = false
# we pretend procs are attached to the type of the first
# argument in order to remove plenty of candidates. This is
# comparable to what C# does and C# is doing fine.
var filterOnlyFirst = false
if optShowAllMismatches notin c.config.globalOptions:
for err in errors:
if err.firstMismatch > 1:
filterOnlyFirst = true
break
var candidates = ""
var skipped = 0
for err in errors:
when false:
if filterOnlyFirst and err.firstMismatch == 1: continue
if filterOnlyFirst and err.firstMismatch == 1:
inc skipped
continue
if err.sym.kind in routineKinds and err.sym.ast != nil:
add(candidates, renderTree(err.sym.ast,
{renderNoBody, renderNoComments, renderNoPragmas}))
@ -216,7 +218,9 @@ proc presentFailedCandidates(c: PContext, n: PNode, errors: CandidateErrors):
"' is immutable\n")
for diag in err.diagnostics:
candidates.add(diag & "\n")
if skipped > 0:
candidates.add($skipped & " other mismatching symbols have been " &
" suppressed; compile with --showAllMismatches:on to see them\n")
result = (prefer, candidates)
const