jyapayne/Nim
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

net: don't clear all errors on close

Browse source 
Closing a socket clears the error queue of the entire thread, which
seems to be a bit too invasive.

Also I don't find any reason in the PR that added this.
This commit is contained in:
Leorize 2020-06-01 20:32:42 -05:00 • committed by Andreas Rumpf
commit d06e6eec79
1 changed files with 0 additions and 1 deletions
Download patch file Download diff file Expand all files Collapse all files

1
lib/pure/net.nim
View file

@ -1006,7 +1006,6 @@ proc close*(socket: Socket) =
try: try:
when defineSsl: when defineSsl:
if socket.isSsl and socket.sslHandle != nil: if socket.isSsl and socket.sslHandle != nil:
ErrClearError()
# Don't call SSL_shutdown if the connection has not been fully # Don't call SSL_shutdown if the connection has not been fully
# established, see: # established, see:
# https://github.com/openssl/openssl/issues/710#issuecomment-253897666 # https://github.com/openssl/openssl/issues/710#issuecomment-253897666