Compute small nim string lit at CT (#20439)

* Reduces runtime overhead for small strings.
* Avoids including `makeNimstrLit` in the output when all strings are
  small enough.
This commit is contained in:
Amjad Ben Hedhili 2022-09-27 10:11:09 +01:00 • committed by GitHub
commit d755c02b02
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23

View file

@ -290,6 +290,21 @@ proc makeJSString(s: string, escapeNonAscii = true): Rope =
else: else:
result = escapeJSString(s).rope result = escapeJSString(s).rope
proc makeJsNimStrLit(s: string): Rope =
var x = newStringOfCap(4*s.len+1)
x.add "["
var i = 0
if i < s.len:
x.addInt int64(s[i])
inc i
while i < s.len:
x.add ","
x.addInt int64(s[i])
inc i
x.add "]"
result = rope(x)
include jstypes include jstypes
proc gen(p: PProc, n: PNode, r: var TCompRes) proc gen(p: PProc, n: PNode, r: var TCompRes)
@ -2605,11 +2620,11 @@ proc gen(p: PProc, n: PNode, r: var TCompRes) =
r.kind = resExpr r.kind = resExpr
of nkStrLit..nkTripleStrLit: of nkStrLit..nkTripleStrLit:
if skipTypes(n.typ, abstractVarRange).kind == tyString: if skipTypes(n.typ, abstractVarRange).kind == tyString:
if n.strVal.len != 0: if n.strVal.len <= 64:
r.res = makeJsNimStrLit(n.strVal)
else:
useMagic(p, "makeNimstrLit") useMagic(p, "makeNimstrLit")
r.res = "makeNimstrLit($1)" % [makeJSString(n.strVal)] r.res = "makeNimstrLit($1)" % [makeJSString(n.strVal)]
else:
r.res = rope"[]"
else: else:
r.res = makeJSString(n.strVal, false) r.res = makeJSString(n.strVal, false)
r.kind = resExpr r.kind = resExpr