jyapayne/Nim
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Fix string stream crashing when created on nimscript due to last fix (#19717)

Browse source
This commit is contained in:
Jason Beetham 2022-04-14 03:30:59 -06:00 • committed by GitHub
commit dc4cc2dca5
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
2 changed files with 5 additions and 1 deletions
Download patch file Download diff file Expand all files Collapse all files

2
lib/pure/streams.nim
View file

@ -1274,7 +1274,7 @@ else: # after 1.3 or JS not defined
new(result) new(result)
result.data = s result.data = s
when defined(gcOrc) or defined(gcArc): when declared(prepareMutation):
prepareMutation(result.data) # Allows us to mutate using `addr` logic like `copyMem`, otherwise it errors. prepareMutation(result.data) # Allows us to mutate using `addr` logic like `copyMem`, otherwise it errors.
result.pos = 0 result.pos = 0
result.closeImpl = ssClose result.closeImpl = ssClose

4
tests/stdlib/tstreams.nim
View file

@ -76,3 +76,7 @@ block:
doAssert(ss.getPosition == 5) # haven't moved doAssert(ss.getPosition == 5) # haven't moved
ss.setPosition(0) # Ensure we dont error with writing over literals on arc/orc #19707 ss.setPosition(0) # Ensure we dont error with writing over literals on arc/orc #19707
ss.write("hello") ss.write("hello")
static: # Ensure streams it doesnt break with nimscript on arc/orc #19716
let s = newStringStream("a")
discard s.data