attempt to make some tests green

lib/system/embedded.nim

@@ -15,14 +15,14 @@ proc chckRange(i, a, b: int): int {.inline, compilerproc.}
 proc chckRangeF(x, a, b: float): float {.inline, compilerproc.}
 proc chckNil(p: pointer) {.inline, compilerproc.}
 
-proc pushFrame(s: PFrame) {.compilerRtl, inl, exportc: "nimFrame".} = nil
-proc popFrame {.compilerRtl, inl.} = nil
+proc pushFrame(s: PFrame) {.compilerRtl, inl, exportc: "nimFrame".} = discard
+proc popFrame {.compilerRtl, inl.} = discard
 
-proc setFrame(s: PFrame) {.compilerRtl, inl.} = nil
-proc pushSafePoint(s: PSafePoint) {.compilerRtl, inl.} = nil
-proc popSafePoint {.compilerRtl, inl.} = nil
-proc pushCurrentException(e: ref E_Base) {.compilerRtl, inl.} = nil
-proc popCurrentException {.compilerRtl, inl.} = nil
+proc setFrame(s: PFrame) {.compilerRtl, inl.} = discard
+proc pushSafePoint(s: PSafePoint) {.compilerRtl, inl.} = discard
+proc popSafePoint {.compilerRtl, inl.} = discard
+proc pushCurrentException(e: ref E_Base) {.compilerRtl, inl.} = discard
+proc popCurrentException {.compilerRtl, inl.} = discard
 
 # some platforms have native support for stack traces:
 const
@@ -38,6 +38,6 @@ proc raiseException(e: ref E_Base, ename: CString) {.compilerRtl.} =
 proc reraiseException() {.compilerRtl.} =
   sysFatal(ENoExceptionToReraise, "no exception to reraise")
 
-proc WriteStackTrace() = nil
+proc writeStackTrace() = discard
 
-proc setControlCHook(hook: proc () {.noconv.}) = nil
+proc setControlCHook(hook: proc () {.noconv.}) = discard

tests/manyloc/argument_parser/argument_parser.nim

@@ -292,9 +292,9 @@ proc parse_parameter(quit_on_failure: bool, param, value: string,
       raise_or_quit(EInvalidValue, ("parameter $1 requires a " &
         "float, but $2 can't be parsed into one") % [param, escape(value)])
   of PK_EMPTY:
-    nil
+    discard
   of PK_HELP:
-    nil
+    discard
 
 
 template build_specification_lookup():

tests/manyloc/keineschweine/lib/estreams.nim

@@ -7,10 +7,6 @@ proc swapEndian16*(outp, inp: pointer) =
   var o = cast[cstring](outp)
   o[0] = i[1]
   o[1] = i[0]
-when cpuEndian == bigEndian:
-  proc bigEndian16(outp, inp: pointer) {.inline.} = copyMem(outp, inp, 2)
-else:
-  proc bigEndian16*(outp, inp: pointer) {.inline.} = swapEndian16(outp, inp)
 
 import enet
 

tests/manyloc/nake/nake.nim

@@ -74,7 +74,7 @@ else:
           echo "Unknown option: ", key, ": ", val
       of cmdArgument:
         task = key
-      else: nil
+      else: discard
     if printTaskList or task.isNil or not(tasks.hasKey(task)):
       echo "Available tasks:"
       for name, task in pairs(tasks):