jyapayne/Nim
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

nimsuggest: fix tcp socket leak (#12377) [backport]

Browse source 
A new socket is created for each iteration and leak immediately thanks
to the accept() call replacing the created socket with the client socket.

This commit fixes that.
This commit is contained in:
alaviss 2019-10-08 06:11:18 +00:00 • committed by Andreas Rumpf
commit e9fa4c9b9c
1 changed files with 1 additions and 1 deletions
Download patch file Download diff file Expand all files Collapse all files

2
nimsuggest/nimsuggest.nim
View file

@ -319,8 +319,8 @@ proc replTcp(x: ThreadParams) {.thread.} =
server.bindAddr(x.port, x.address) server.bindAddr(x.port, x.address)
server.listen() server.listen()
var inp = "".TaintedString var inp = "".TaintedString
var stdoutSocket: Socket
while true: while true:
var stdoutSocket = newSocket()
accept(server, stdoutSocket) accept(server, stdoutSocket)
stdoutSocket.readLine(inp) stdoutSocket.readLine(inp)