jyapayne/Nim
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Warns to not modify string findAll is iterating over.

Browse source
This commit is contained in:
Grzegorz Adam Hankiewicz 2013-07-16 02:00:25 +02:00
commit ec6e267351
1 changed files with 4 additions and 1 deletions
Download patch file Download diff file Expand all files Collapse all files

5
lib/impure/re.nim
View file

@ -201,7 +201,10 @@ proc find*(s: string, pattern: TRegEx, start = 0): int =
return rawMatches[0] return rawMatches[0]
iterator findAll*(s: string, pattern: TRegEx, start = 0): string = iterator findAll*(s: string, pattern: TRegEx, start = 0): string =
## yields all matching *substrings* of `s` that match `pattern`. ## Yields all matching *substrings* of `s` that match `pattern`.
##
## Note that since this is an iterator you should not modify the string you
## are iterating over: bad things could happen.
var i = int32(start) var i = int32(start)
var rawMatches: array[0..maxSubpatterns * 3 - 1, cint] var rawMatches: array[0..maxSubpatterns * 3 - 1, cint]
while true: while true: