jyapayne/Nim
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Fix nimIdentNormalize, fixes #19067 (#19068)

Browse source 
* Make nimIdentNormalize return "" when passed ""; fixes #19067

Fixes #19067

* Add tests for nimIdentNormalize
This commit is contained in:
Tomasz Kramkowski 2021-10-29 10:39:41 +01:00 • committed by GitHub
commit ee703c5db4
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
2 changed files with 10 additions and 2 deletions
Download patch file Download diff file Expand all files Collapse all files

3
lib/pure/strutils.nim
View file

@ -281,7 +281,8 @@ func nimIdentNormalize*(s: string): string =
runnableExamples: runnableExamples:
doAssert nimIdentNormalize("Foo_bar") == "Foobar" doAssert nimIdentNormalize("Foo_bar") == "Foobar"
result = newString(s.len) result = newString(s.len)
if s.len > 0: if s.len == 0:
return
result[0] = s[0] result[0] = s[0]
var j = 1 var j = 1
for i in 1..len(s) - 1: for i in 1..len(s) - 1:

7
tests/stdlib/tstrutils.nim
View file

@ -841,5 +841,12 @@ bar
doAssert s.endsWith('a') == false doAssert s.endsWith('a') == false
doAssert s.endsWith('\0') == false doAssert s.endsWith('\0') == false
block: # nimIdentNormalize
doAssert nimIdentNormalize("") == ""
doAssert nimIdentNormalize("foo") == "foo"
doAssert nimIdentNormalize("foo_bar") == "foobar"
doAssert nimIdentNormalize("Foo_bar") == "Foobar"
doAssert nimIdentNormalize("_Foo_bar") == "_foobar"
static: main() static: main()
main() main()