jyapayne/Nim
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Better error message and tests for bad await (#19622)

Browse source 
* Better error message and tests for bad await

* Use compiles to check if await is valid

* temp: disable windows noasync test

* Better error report, simplify test

Co-authored-by: flywind <xzsflywind@gmail.com>
This commit is contained in:
huantian 2022-04-13 14:03:46 -07:00 • committed by GitHub
commit ef7d7f2459
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
2 changed files with 45 additions and 6 deletions
Download patch file Download diff file Expand all files Collapse all files

35
tests/async/tasync_noasync.nim
View file

@ -1,13 +1,42 @@
discard """
errormsg: "'yield' only allowed in an iterator"
cmd: "nim c $file"
file: "asyncmacro.nim"
cmd: "nim check --hints:off --warnings:off $file"
action: "reject"
nimout: '''
tasync_noasync.nim(21, 10) Error: Can only 'await' inside a proc marked as 'async'. Use 'waitFor' when calling an 'async' proc in a non-async scope instead
tasync_noasync.nim(25, 12) Error: Can only 'await' inside a proc marked as 'async'. Use 'waitFor' when calling an 'async' proc in a non-async scope instead
tasync_noasync.nim(28, 10) Error: Can only 'await' inside a proc marked as 'async'. Use 'waitFor' when calling an 'async' proc in a non-async scope instead
tasync_noasync.nim(31, 10) Error: Can only 'await' inside a proc marked as 'async'. Use 'waitFor' when calling an 'async' proc in a non-async scope instead
tasync_noasync.nim(35, 10) Error: Can only 'await' inside a proc marked as 'async'. Use 'waitFor' when calling an 'async' proc in a non-async scope instead
tasync_noasync.nim(38, 10) Error: Can only 'await' inside a proc marked as 'async'. Use 'waitFor' when calling an 'async' proc in a non-async scope instead
tasync_noasync.nim(40, 8) Error: Can only 'await' inside a proc marked as 'async'. Use 'waitFor' when calling an 'async' proc in a non-async scope instead
'''
"""
import async
proc a {.async.} =
discard
# Bad await usage
proc nonAsyncProc =
await a()
proc nestedNonAsyncProc {.async.} =
proc nested =
await a()
iterator customIterator: int =
await a()
macro awaitInMacro =
await a()
type DummyRef = ref object of RootObj
method awaitInMethod(_: DummyRef) {.base.} =
await a()
proc improperMultisync {.multisync.} =
await a()
await a()
# if we overload a fallback handler to get