jyapayne/Nim
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Merge pull request #11263 from jrfondren/asyncstreams-fix-immediately-vs-soon

Browse source 
fix unnecessary poll() (and default 500ms delay) in some uses of async
This commit is contained in:
Dominik Picheta 2019-05-16 23:24:53 +01:00 • committed by GitHub
commit f1a8edc14d
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
1 changed files with 6 additions and 1 deletions
Download patch file Download diff file Expand all files Collapse all files

7
lib/pure/asyncstreams.nim
View file

@ -79,7 +79,7 @@ proc read*[T](future: FutureStream[T]): Future[(bool, T)] =
## ``FutureStream``. ## ``FutureStream``.
var resFut = newFuture[(bool, T)]("FutureStream.take") var resFut = newFuture[(bool, T)]("FutureStream.take")
let savedCb = future.cb let savedCb = future.cb
future.callback = var newCb =
proc (fs: FutureStream[T]) = proc (fs: FutureStream[T]) =
# Exit early if `resFut` is already complete. (See #8994). # Exit early if `resFut` is already complete. (See #8994).
if resFut.finished: return if resFut.finished: return
@ -100,6 +100,11 @@ proc read*[T](future: FutureStream[T]): Future[(bool, T)] =
# If the saved callback isn't nil then let's call it. # If the saved callback isn't nil then let's call it.
if not savedCb.isNil: savedCb() if not savedCb.isNil: savedCb()
if future.queue.len > 0 or future.finished:
newCb(future)
else:
future.callback = newCb
return resFut return resFut
proc len*[T](future: FutureStream[T]): int = proc len*[T](future: FutureStream[T]): int =