jyapayne/Nim
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Fix Httpclient headers from being modified accidentally (#17808)

Browse source
This commit is contained in:
Joey 2021-04-20 23:42:04 -06:00 • committed by GitHub
commit f1ce173283
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
1 changed files with 5 additions and 2 deletions
Download patch file Download diff file Expand all files Collapse all files

7
lib/pure/httpclient.nim
View file

@ -962,12 +962,15 @@ proc format(client: HttpClient | AsyncHttpClient,
proc override(fallback, override: HttpHeaders): HttpHeaders = proc override(fallback, override: HttpHeaders): HttpHeaders =
# Right-biased map union for `HttpHeaders` # Right-biased map union for `HttpHeaders`
if override.isNil:
return fallback
result = newHttpHeaders() result = newHttpHeaders()
# Copy by value # Copy by value
result.table[] = fallback.table[] result.table[] = fallback.table[]
if override.isNil:
# Return the copy of fallback so it does not get modified
return result
for k, vs in override.table: for k, vs in override.table:
result[k] = vs result[k] = vs