jyapayne/Nim
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

fix #17952: fix both false positives and false negatives for reInvalidSpec (#17956)

Browse source 
* fix #17952: fix both false positives and false negatives for reInvalidSpec

* handle megatest properly

* fix for tests/stdlib/tbase64.nim
This commit is contained in:
Timothee Cour 2021-05-07 15:22:21 -07:00 • committed by GitHub
commit fb677bf5c9
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
6 changed files with 69 additions and 43 deletions
Download patch file Download diff file Expand all files Collapse all files

11
testament/categories.nim
View file

@ -600,12 +600,19 @@ proc runJoinedTest(r: var TResults, cat: Category, testsDir: string, options: st
]#
var specs: seq[TSpec] = @[]
for kind, dir in walkDir(testsDir):
assert testsDir.startsWith(testsDir)
assert dir.startsWith(testsDir)
let cat = dir[testsDir.len .. ^1]
if kind == pcDir and cat notin specialCategories:
for file in walkDirRec(testsDir / cat):
if isTestFile(file):
let spec = parseSpec(file)
var spec: TSpec
try:
spec = parseSpec(file)
except ValueError:
# e.g. for `tests/navigator/tincludefile.nim` which have multiple
# specs; this will be handled elsewhere
echo "parseSpec failed for: '$1', assuming this will be handled outside of megatest" % file
continue
if isJoinableSpec(spec):
specs.add spec