fix #17952: fix both false positives and false negatives for reInvalidSpec (#17956)

* fix #17952: fix both false positives and false negatives for reInvalidSpec

* handle megatest properly

* fix for tests/stdlib/tbase64.nim
This commit is contained in:
Timothee Cour 2021-05-07 15:22:21 -07:00 • committed by GitHub
commit fb677bf5c9
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
6 changed files with 69 additions and 43 deletions

View file

@ -193,28 +193,28 @@ proc setActive*(t: PTextEntry) =
if not t.isNil and not t.inputClient.isNil:
input_helpers.setActive(t.inputClient)
when false:
proc newMessageArea*(container: PGuiContainer; position: TVector2f): PMessageArea =
new(result)
result.messages = @[]
result.pos = position
container.add(result)
proc add*(m: PMessageArea, text: string): PText =
result = messageProto.copy()
result.setString(text)
m.messages.add(result)
let nmsgs = len(m.messages)
var pos = vec2f(m.pos.x, m.pos.y)
for i in countdown(nmsgs - 1, max(nmsgs - 30, 0)):
setPosition(m.messages[i], pos)
pos.y -= 16.0
discard """proc newMessageArea*(container: PGuiContainer; position: TVector2f): PMessageArea =
new(result)
result.messages = @[]
result.pos = position
container.add(result)
proc add*(m: PMessageArea, text: string): PText =
result = messageProto.copy()
result.setString(text)
m.messages.add(result)
let nmsgs = len(m.messages)
var pos = vec2f(m.pos.x, m.pos.y)
for i in countdown(nmsgs - 1, max(nmsgs - 30, 0)):
setPosition(m.messages[i], pos)
pos.y -= 16.0
proc draw*(window: PRenderWindow; m: PMessageArea) =
let nmsgs = len(m.messages)
if nmsgs == 0: return
for i in countdown(nmsgs - 1, max(nmsgs - 30, 0)):
window.draw(m.messages[i])
proc draw*(window: PRenderWindow; m: PMessageArea) =
let nmsgs = len(m.messages)
if nmsgs == 0: return
for i in countdown(nmsgs - 1, max(nmsgs - 30, 0)):
window.draw(m.messages[i])
"""
proc newMessageArea*(container: PGuiContainer; position: TVector2f): PMessageArea =
new(result)
result.messages = @[]

View file

@ -29,11 +29,12 @@ task "test2", "Build release test build test release build":
if shell("nim", ReleaseDefines, ReleaseTestDefines, "compile", ExeName) == 0:
shell "."/ExeName
discard """task "dirserver", "build the directory server":
withDir "server":
if shell("nim", ServerDefines, "compile", "dirserver") != 0:
echo "Failed to build the dirserver"
quit 1"""
when false:
task "dirserver", "build the directory server":
withDir "server":
if shell("nim", ServerDefines, "compile", "dirserver") != 0:
echo "Failed to build the dirserver"
quit 1
task "zoneserver", "build the zone server":
withDir "enet_server":