jyapayne/Nim
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

fix #8242, fix #12586: fix 'formatFloat' with 'precision = 0' (#12592)

Browse source 
* fix #8242, fix #12586: fix 'formatFloat' with 'precision = 0'

'formatFloat' with 'precision = 0' now gives the same result
(a number without a decimal point) in all backends.
This is compatible with Python's formatters, too.

* fix failing tests

* add changelog entry

* add version switch
This commit is contained in:
Miran 2019-11-05 10:31:23 +01:00 • committed by Andreas Rumpf
commit ffa9a7405f
4 changed files with 39 additions and 28 deletions
Download patch file Download diff file Expand all files Collapse all files

3
tests/destructor/tnewruntime_strutils.nim
View file

@ -14,8 +14,7 @@ proc retTuple(): (seq[int], int) =
proc nonStaticTests =
doAssert formatBiggestFloat(1234.567, ffDecimal, -1) == "1234.567000"
when not defined(js):
doAssert formatBiggestFloat(1234.567, ffDecimal, 0) == "1235." # <=== bug 8242
doAssert formatBiggestFloat(1234.567, ffDecimal, 0) == "1235" # bugs 8242, 12586
doAssert formatBiggestFloat(1234.567, ffDecimal, 1) == "1234.6"
doAssert formatBiggestFloat(0.00000000001, ffDecimal, 11) == "0.00000000001"
doAssert formatBiggestFloat(0.00000000001, ffScientific, 1, ',') in