* Fix issue with long wait for passed timer [bugfix] This fixes a small issue where a timer that had been completed while code executed would still wait for more events before being considered completed. This would in some scenarios incur a 500ms delay to the completion of a timer. * Refactor logic into * Add test case based on original issue * Use longer timeouts to be more lenient in checking * Revert to short timeouts, but widen the accepted range * Widen accepted range further, it is meant to check for a 500ms delay after all * Increase poll timeout to make it easier to detect mistakes
52 lines
1.5 KiB
Nim
52 lines
1.5 KiB
Nim
import asyncdispatch, os, times
|
|
|
|
proc doubleSleep(hardSleep: int) {.async.} =
|
|
await sleepAsync(100)
|
|
sleep(hardSleep)
|
|
|
|
template assertTime(target, timeTook: float): untyped {.dirty.} =
|
|
assert(timeTook*1000 > target - 1000, "Took too short, should've taken " &
|
|
$target & "ms, but took " & $(timeTook*1000) & "ms")
|
|
assert(timeTook*1000 < target + 1000, "Took too long, should've taken " &
|
|
$target & "ms, but took " & $(timeTook*1000) & "ms")
|
|
|
|
var
|
|
start: float
|
|
fut: Future[void]
|
|
|
|
# NOTE: this uses poll(3000) to limit timing error potential.
|
|
start = epochTime()
|
|
fut = sleepAsync(50) and sleepAsync(150) and doubleSleep(40)
|
|
while not fut.finished:
|
|
poll(3000)
|
|
assertTime(150, epochTime() - start)
|
|
|
|
start = epochTime()
|
|
fut = sleepAsync(50) and sleepAsync(150) and doubleSleep(100)
|
|
while not fut.finished:
|
|
poll(3000)
|
|
assertTime(200, epochTime() - start)
|
|
|
|
start = epochTime()
|
|
fut = sleepAsync(50) and sleepAsync(150) and doubleSleep(40) and sleepAsync(300)
|
|
while not fut.finished:
|
|
poll(3000)
|
|
assertTime(300, epochTime() - start)
|
|
|
|
start = epochTime()
|
|
fut = sleepAsync(50) and sleepAsync(150) and doubleSleep(100) and sleepAsync(300)
|
|
while not fut.finished:
|
|
poll(3000)
|
|
assertTime(300, epochTime() - start)
|
|
|
|
start = epochTime()
|
|
fut = (sleepAsync(50) and sleepAsync(150) and doubleSleep(40)) or sleepAsync(700)
|
|
while not fut.finished:
|
|
poll(3000)
|
|
assertTime(150, epochTime() - start)
|
|
|
|
start = epochTime()
|
|
fut = (sleepAsync(50) and sleepAsync(150) and doubleSleep(100)) or sleepAsync(700)
|
|
while not fut.finished:
|
|
poll(3000)
|
|
assertTime(200, epochTime() - start)
|