jyapayne/PySide
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Fix QTreeWidgetItem.parent function.

Browse source 
Create unit test for new use case.
Fixes bug #547

Reviewer: Marcelo Lira <marcelo.lira@openbossa.org>
          Hugo Parente Lima <hugo.pl@gmail.com>
This commit is contained in:
Renato Araujo Oliveira Filho 2011-01-03 14:21:40 -03:00
commit 39a5a09145
2 changed files with 20 additions and 3 deletions
Download patch file Download diff file Expand all files Collapse all files

2
PySide/QtGui/typesystem_gui_common.xml
View file

@ -3231,7 +3231,7 @@
<parent index="this" action="add"/> <parent index="this" action="add"/>
</modify-argument> </modify-argument>
</modify-function> </modify-function>
<modify-function signature="parent()"> <modify-function signature="parent() const">
<modify-argument index="this"> <modify-argument index="this">
<parent index="return" action="add"/> <parent index="return" action="add"/>
</modify-argument> </modify-argument>

21
tests/QtGui/bug_547.py
View file

@ -6,8 +6,8 @@ import sys
import unittest import unittest
class MyMainWindow(unittest.TestCase): class MyMainWindow(unittest.TestCase):
def testClearFunction(self): app = QtGui.QApplication(sys.argv)
app = QtGui.QApplication(sys.argv) def testCase1(self):
self._tree = QtGui.QTreeWidget() self._tree = QtGui.QTreeWidget()
self._tree.setColumnCount(2) self._tree.setColumnCount(2)
self._i1 = None self._i1 = None
@ -24,6 +24,21 @@ class MyMainWindow(unittest.TestCase):
self.assertEqual(sys.getrefcount(self._i1), 3) self.assertEqual(sys.getrefcount(self._i1), 3)
self.assertEqual(sys.getrefcount(self._i11), 3) self.assertEqual(sys.getrefcount(self._i11), 3)
def testCase2(self):
self._tree = QtGui.QTreeWidget()
self._tree.setColumnCount(2)
self._i1 = None
self._i11 = None
self._updateTree()
self.assertEqual(sys.getrefcount(self._i1), 3)
self.assertEqual(sys.getrefcount(self._i11), 3)
self._i11.parent().setExpanded(True)
self._i11.setExpanded(True)
self.assertEqual(sys.getrefcount(self._i1), 3)
self.assertEqual(sys.getrefcount(self._i11), 3)
def _updateTree(self): def _updateTree(self):
self._tree.clear() self._tree.clear()
@ -32,7 +47,9 @@ class MyMainWindow(unittest.TestCase):
self.assertEqual(sys.getrefcount(self._i11), 2) self.assertEqual(sys.getrefcount(self._i11), 2)
self._i1 = QtGui.QTreeWidgetItem(self._tree, ['1', ]) self._i1 = QtGui.QTreeWidgetItem(self._tree, ['1', ])
self.assertEqual(sys.getrefcount(self._i1), 3)
self._i11 = QtGui.QTreeWidgetItem(self._i1, ['11', ]) self._i11 = QtGui.QTreeWidgetItem(self._i1, ['11', ])
self.assertEqual(sys.getrefcount(self._i11), 3)
if __name__ == '__main__': if __name__ == '__main__':
unittest.main() unittest.main()