jyapayne/PySide
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Fixed crash on qsignal destructor.

Browse source 
Reviewer: Hugo Parente Lima <hugo.pl@gmail.com>
          Luciano Wolf <luciano.wolf@openbossa.org>
This commit is contained in:
renatofilho 2010-09-13 19:25:41 -03:00
commit b315368a1b
1 changed files with 3 additions and 3 deletions
Download patch file Download diff file Expand all files Collapse all files

6
libpyside/qsignal.cpp
View file

@ -226,7 +226,7 @@ void signalUpdateSource(PyObject* source)
PyObject *attrName = PyList_GET_ITEM(attrs.object(), i); PyObject *attrName = PyList_GET_ITEM(attrs.object(), i);
Shiboken::AutoDecRef attr(PyObject_GetAttr(reinterpret_cast<PyObject*>(source->ob_type), attrName)); Shiboken::AutoDecRef attr(PyObject_GetAttr(reinterpret_cast<PyObject*>(source->ob_type), attrName));
if (attr->ob_type == &Signal_Type) { if (attr->ob_type == &Signal_Type) {
Shiboken::AutoDecRef signalInstance(_PyObject_New(&SignalInstance_Type)); Shiboken::AutoDecRef signalInstance((PyObject*)PyObject_New(SignalInstanceData, &SignalInstance_Type));
signal_instance_initialize(signalInstance, attrName, reinterpret_cast<SignalData*>(attr.object()), source, 0); signal_instance_initialize(signalInstance, attrName, reinterpret_cast<SignalData*>(attr.object()), source, 0);
PyObject_SetAttr(source, attrName, signalInstance); PyObject_SetAttr(source, attrName, signalInstance);
} }
@ -365,9 +365,9 @@ void signal_instance_free(void* self)
free(data->signalName); free(data->signalName);
free(data->signature); free(data->signature);
while(data) { if (data->next) {
Py_XDECREF(data->next); Py_XDECREF(data->next);
data = reinterpret_cast<SignalInstanceData*>(data->next); data->next = 0;
} }
pySelf->ob_type->tp_base->tp_free(self); pySelf->ob_type->tp_base->tp_free(self);
} }