jyapayne/PySide
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Change the order of function call on destructionVisitor to avoid problems with cyclic dependency.

Browse source 
Fixes bug #793.

Reviewer: Luciano Wolf <luciano.wolf@openbossa.org>
          Hugo Parente <hugo.lima@openbossa.org>
This commit is contained in:
Renato Filho 2011-04-04 18:06:07 -03:00
commit e39188d636
1 changed files with 2 additions and 1 deletions
Download patch file Download diff file Expand all files Collapse all files

3
libpyside/pyside.cpp
View file

@ -113,10 +113,11 @@ static void destructionVisitor(SbkObject* pyObj, void* data)
if (pyObj != pyQApp && PyObject_TypeCheck(pyObj, pyQObjectType)) { if (pyObj != pyQApp && PyObject_TypeCheck(pyObj, pyQObjectType)) {
if (Shiboken::Object::hasOwnership(pyObj) && Shiboken::Object::isValid(pyObj, false)) { if (Shiboken::Object::hasOwnership(pyObj) && Shiboken::Object::isValid(pyObj, false)) {
Shiboken::Object::setValidCpp(pyObj, false);
Py_BEGIN_ALLOW_THREADS Py_BEGIN_ALLOW_THREADS
Shiboken::callCppDestructor<QObject>(Shiboken::Object::cppPointer(pyObj, pyQObjectType)); Shiboken::callCppDestructor<QObject>(Shiboken::Object::cppPointer(pyObj, pyQObjectType));
Py_END_ALLOW_THREADS Py_END_ALLOW_THREADS
Shiboken::Object::setValidCpp(pyObj, false);
} }
} }
}; };