jyapayne/ace
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

remove $ function and property from EventEmitter

Browse source
This commit is contained in:
Joe Walker 2010-11-23 15:52:44 +00:00
commit 10843ba7e6
11 changed files with 60 additions and 59 deletions
Download patch file Download diff file Expand all files Collapse all files

6
plugins/pilot/lib/canon.js
View file

@ -130,7 +130,7 @@ exports.addRequestOutput = function(request) {
exports.requests.shiftObject();
}
exports.$dispatchEvent('addedRequestOutput', { request: request });
exports._dispatchEvent('addedRequestOutput', { request: request });
};
/**
@ -238,7 +238,7 @@ exports.Request.prototype.output = function(content) {
}
this.outputs.push(content);
this.$dispatchEvent('changed', {});
this._dispatchEvent('changed', {});
return this;
};
@ -256,7 +256,7 @@ exports.Request.prototype.done = function(content) {
this.output(content);
}
this.$dispatchEvent('changed', {});
this._dispatchEvent('changed', {});
};
});

71
plugins/pilot/lib/event_emitter.js
View file

@ -37,49 +37,50 @@
define(function(require, exports, module) {
var lang = require("pilot/lang").lang;
var lang = require("pilot/lang").lang;
var EventEmitter = {};
var EventEmitter = {};
EventEmitter.$dispatchEvent = function(eventName, e) {
this.$eventRegistry = this.$eventRegistry || {};
EventEmitter._dispatchEvent = function(eventName, e) {
this._eventRegistry = this._eventRegistry || {};
var listeners = this.$eventRegistry[eventName];
if (!listeners || !listeners.length) return;
var listeners = this._eventRegistry[eventName];
if (!listeners || !listeners.length) return;
var e = e || {};
e.type = eventName;
var e = e || {};
e.type = eventName;
for (var i=0; i<listeners.length; i++) {
listeners[i](e);
}
};
for (var i=0; i<listeners.length; i++) {
listeners[i](e);
}
};
EventEmitter.on =
EventEmitter.addEventListener = function(eventName, callback) {
this.$eventRegistry = this.$eventRegistry || {};
EventEmitter.on =
EventEmitter.addEventListener = function(eventName, callback) {
this._eventRegistry = this._eventRegistry || {};
var listeners = this.$eventRegistry[eventName];
if (!listeners) {
var listeners = this.$eventRegistry[eventName] = [];
}
if (lang.arrayIndexOf(listeners, callback) == -1) {
listeners.push(callback);
}
};
var listeners = this._eventRegistry[eventName];
if (!listeners) {
var listeners = this._eventRegistry[eventName] = [];
}
if (lang.arrayIndexOf(listeners, callback) == -1) {
listeners.push(callback);
}
};
EventEmitter.removeEventListener = function(eventName, callback) {
this.$eventRegistry = this.$eventRegistry || {};
EventEmitter.removeEventListener = function(eventName, callback) {
this._eventRegistry = this._eventRegistry || {};
var listeners = this.$eventRegistry[eventName];
if (!listeners) {
return;
}
var index = lang.arrayIndexOf(listeners, callback);
if (index !== -1) {
listeners.splice(index, 1);
}
};
var listeners = this._eventRegistry[eventName];
if (!listeners) {
return;
}
var index = lang.arrayIndexOf(listeners, callback);
if (index !== -1) {
listeners.splice(index, 1);
}
};
exports.EventEmitter = EventEmitter;
exports.EventEmitter = EventEmitter;
});

2
plugins/pilot/lib/settings.js
View file

@ -230,7 +230,7 @@ Settings.prototype = {
persister.persistValue(this, key, value);
}
this.$dispatchEvent('settingChange', { key: key, value: value });
this._dispatchEvent('settingChange', { key: key, value: value });
return this;
},