From 269e8d976dbea688371373c59e532740524bbc66 Mon Sep 17 00:00:00 2001 From: nightwing Date: Wed, 14 Aug 2013 00:05:26 +0400 Subject: [PATCH] remove useless stopPropagation on mouseup --- lib/ace/lib/event.js | 14 ++++++-------- 1 file changed, 6 insertions(+), 8 deletions(-) diff --git a/lib/ace/lib/event.js b/lib/ace/lib/event.js index ca210203..42b77eaf 100644 --- a/lib/ace/lib/event.js +++ b/lib/ace/lib/event.js @@ -131,8 +131,6 @@ else { document.removeEventListener("mousemove", eventHandler, true); document.removeEventListener("mouseup", onMouseUp, true); - - e.stopPropagation(); } document.addEventListener("mousemove", eventHandler, true); @@ -241,11 +239,11 @@ function normalizeCommandKeys(callback, e, keyCode) { else return; } - if (keyCode == 18 || keyCode == 17) { + if (keyCode === 18 || keyCode === 17) { var location = e.location || e.keyLocation; - if (keyCode == 17 && location == 1) { + if (keyCode === 17 && location === 1) { ts = e.timeStamp; - } else if (keyCode == 18 && hashId == 3 && location == 2) { + } else if (keyCode === 18 && hashId === 3 && location === 2) { var dt = -ts; ts = e.timeStamp; dt += ts; @@ -273,12 +271,12 @@ function normalizeCommandKeys(callback, e, keyCode) { keyCode = 0; } - if (hashId & 8 && (keyCode == 91 || keyCode == 93)) { + if (hashId & 8 && (keyCode === 91 || keyCode === 93)) { keyCode = 0; } - if (!hashId && keyCode == 13) { - if (e.keyLocation || e.location == 3) { + if (!hashId && keyCode === 13) { + if (e.location || e.keyLocation === 3) { callback(e, hashId, -keyCode) if (e.defaultPrevented) return;