From 5e64876ce72302cbafef9df36aacd75b0eb7eae3 Mon Sep 17 00:00:00 2001 From: Lennart Kats Date: Mon, 15 Oct 2012 15:24:37 +0200 Subject: [PATCH 1/2] Support console.log/error with non-array arguments --- lib/ace/worker/worker.js | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/lib/ace/worker/worker.js b/lib/ace/worker/worker.js index 0e7270a3..9a258575 100644 --- a/lib/ace/worker/worker.js +++ b/lib/ace/worker/worker.js @@ -2,7 +2,12 @@ var console = { log: function(msgs) { - postMessage({type: "log", data: arguments.join(" ")}); + msgs = Array.prototype.slice.call(arguments, 0); + postMessage({type: "log", data: msgs}); + }, + error: function(msgs) { + msgs = Array.prototype.slice.call(arguments, 0); + postMessage({type: "log", data: msgs}); } }; var window = { From 08bce08db5991f3ca22e4e48ba68f92ab5195d03 Mon Sep 17 00:00:00 2001 From: Mostafa Eweda Date: Mon, 15 Oct 2012 18:12:32 +0200 Subject: [PATCH 2/2] log multiple arguments support + Remove unused msgs argument --- lib/ace/worker/worker.js | 8 ++++---- lib/ace/worker/worker_client.js | 2 +- 2 files changed, 5 insertions(+), 5 deletions(-) diff --git a/lib/ace/worker/worker.js b/lib/ace/worker/worker.js index 9a258575..faf5624e 100644 --- a/lib/ace/worker/worker.js +++ b/lib/ace/worker/worker.js @@ -1,12 +1,12 @@ "no use strict"; var console = { - log: function(msgs) { - msgs = Array.prototype.slice.call(arguments, 0); + log: function() { + var msgs = Array.prototype.slice.call(arguments, 0); postMessage({type: "log", data: msgs}); }, - error: function(msgs) { - msgs = Array.prototype.slice.call(arguments, 0); + error: function() { + var msgs = Array.prototype.slice.call(arguments, 0); postMessage({type: "log", data: msgs}); } }; diff --git a/lib/ace/worker/worker_client.js b/lib/ace/worker/worker_client.js index 79169ea4..d3b9c3c8 100644 --- a/lib/ace/worker/worker_client.js +++ b/lib/ace/worker/worker_client.js @@ -84,7 +84,7 @@ var WorkerClient = function(topLevelNamespaces, mod, classname) { var msg = e.data; switch(msg.type) { case "log": - window.console && console.log && console.log(msg.data); + window.console && console.log && console.log.apply(console, msg.data); break; case "event":