jyapayne/ace
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Fix EditSession.removeFolds: Using the folds of a foldLine might cause unexpected behavior. Clone the passed in array.

Browse source
This commit is contained in:
Julian Viereck 2011-04-25 22:54:32 +02:00
commit 2be2386603
1 changed files with 9 additions and 7 deletions
Download patch file Download diff file Expand all files Collapse all files

16
lib/ace/edit_session.js
View file

@ -968,12 +968,6 @@ var EditSession = function(text, mode) {
this.removeFolds(this.getFoldsInRange(e.data.range)); this.removeFolds(this.getFoldsInRange(e.data.range));
len = -len; len = -len;
} }
// if (action.indexOf("insert") != -1) {
// column = start.column;
// } else {
// column = end.column;
// len = -len;
// }
var foldLine = this.getFoldLine(firstRow); var foldLine = this.getFoldLine(firstRow);
if (foldLine) { if (foldLine) {
foldLine.addRemoveChars(firstRow, start.column, len); foldLine.addRemoveChars(firstRow, start.column, len);
@ -1927,7 +1921,15 @@ var EditSession = function(text, mode) {
} }
this.removeFolds = function(folds) { this.removeFolds = function(folds) {
folds.forEach(function(fold) { // We need to clone the folds array passed in as it might be the folds
// array of a fold line and as we call this.removeFold(fold), folds
// are removed from folds and changes the current index.
var cloneFolds = [];
for (var i = 0; i < folds.length; i++) {
cloneFolds.push(folds[i]);
}
cloneFolds.forEach(function(fold) {
this.removeFold(fold); this.removeFold(fold);
}, this); }, this);
} }