From 2c32e739911360d0101694cc6339f4491090e2af Mon Sep 17 00:00:00 2001 From: Fabian Jakobs Date: Fri, 14 Jan 2011 16:14:36 +0100 Subject: [PATCH] small changes to the new key handler code --- demo/startup.js | 8 +++----- lib/ace/editor.js | 2 +- lib/ace/keyboard/keybinding.js | 8 ++++---- .../keybindings => keyboard/keybinding}/default_mac.js | 0 .../keybindings => keyboard/keybinding}/default_win.js | 0 lib/ace/keyboard/{ => keybinding}/emacs.js | 0 lib/ace/keyboard/{ => keybinding}/vim.js | 0 7 files changed, 8 insertions(+), 10 deletions(-) rename lib/ace/{conf/keybindings => keyboard/keybinding}/default_mac.js (100%) rename lib/ace/{conf/keybindings => keyboard/keybinding}/default_win.js (100%) rename lib/ace/keyboard/{ => keybinding}/emacs.js (100%) rename lib/ace/keyboard/{ => keybinding}/vim.js (100%) diff --git a/demo/startup.js b/demo/startup.js index bb4663b7..b2e473a8 100644 --- a/demo/startup.js +++ b/demo/startup.js @@ -55,8 +55,8 @@ exports.launch = function(env) { var TextMode = require("ace/mode/text").Mode; var UndoManager = require("ace/undomanager").UndoManager; - var vim = require("ace/keyboard/vim").Vim; - var emacs = require("ace/keyboard/emacs").Emacs; + var vim = require("ace/keyboard/keybinding/vim").Vim; + var emacs = require("ace/keyboard/keybinding/emacs").Emacs; var HashHandler = require("ace/keyboard/hash_handler").HashHandler; var docs = {}; @@ -84,7 +84,6 @@ exports.launch = function(env) { var container = document.getElementById("editor"); env.editor = new Editor(new Renderer(container, theme)); -<<<<<<< HEAD:demo/startup.js var modes = { text: new TextMode(), @@ -107,7 +106,7 @@ exports.launch = function(env) { } modeEl.onchange = setMode; setMode(); -======= + // This is how you can set a custom keyboardHandler. // // Define some basic keymapping using a hash: @@ -117,7 +116,6 @@ exports.launch = function(env) { // // Use a more complex keymapping: // env.editor.setKeyboardHandler(vim); ->>>>>>> jviereck/keymapping:demo/demo_startup.js var docEl = document.getElementById("doc"); function onDocChange() { diff --git a/lib/ace/editor.js b/lib/ace/editor.js index 2ca39c43..05f187b5 100644 --- a/lib/ace/editor.js +++ b/lib/ace/editor.js @@ -488,7 +488,7 @@ var Editor =function(renderer, doc) { } this.onTextInput = function(text) { - this.keyBinding.onTextInput.call(this.keyBinding, text); + this.keyBinding.onTextInput(text); }; this.onCommandKey = function(e, hashId, keyCode) { diff --git a/lib/ace/keyboard/keybinding.js b/lib/ace/keyboard/keybinding.js index 8d309126..315f56f9 100644 --- a/lib/ace/keyboard/keybinding.js +++ b/lib/ace/keyboard/keybinding.js @@ -43,8 +43,8 @@ var keyUtil = require("pilot/keys"); var event = require("pilot/event"); var settings = require("pilot/settings").settings; var HashHandler = require("ace/keyboard/hash_handler").HashHandler; -var default_mac = require("ace/conf/keybindings/default_mac").bindings; -var default_win = require("ace/conf/keybindings/default_win").bindings; +var default_mac = require("ace/keyboard/keybinding/default_mac").bindings; +var default_win = require("ace/keyboard/keybinding/default_win").bindings; var canon = require("pilot/canon"); require("ace/commands/default_commands"); @@ -53,8 +53,8 @@ var KeyBinding = function(editor, config) { this.$data = { }; this.$keyboardHandler = null; this.$defaulKeyboardHandler = new HashHandler(config || (useragent.isMac - ? default_mac - : default_win)); + ? default_mac + : default_win)); }; (function() { diff --git a/lib/ace/conf/keybindings/default_mac.js b/lib/ace/keyboard/keybinding/default_mac.js similarity index 100% rename from lib/ace/conf/keybindings/default_mac.js rename to lib/ace/keyboard/keybinding/default_mac.js diff --git a/lib/ace/conf/keybindings/default_win.js b/lib/ace/keyboard/keybinding/default_win.js similarity index 100% rename from lib/ace/conf/keybindings/default_win.js rename to lib/ace/keyboard/keybinding/default_win.js diff --git a/lib/ace/keyboard/emacs.js b/lib/ace/keyboard/keybinding/emacs.js similarity index 100% rename from lib/ace/keyboard/emacs.js rename to lib/ace/keyboard/keybinding/emacs.js diff --git a/lib/ace/keyboard/vim.js b/lib/ace/keyboard/keybinding/vim.js similarity index 100% rename from lib/ace/keyboard/vim.js rename to lib/ace/keyboard/keybinding/vim.js