Fix highlighter rules to not become global objects

lib/ace/mode/c_cpp_highlight_rules.js

@@ -45,7 +45,7 @@ var lang = require("pilot/lang");
 var DocCommentHighlightRules = require("ace/mode/doc_comment_highlight_rules").DocCommentHighlightRules;
 var TextHighlightRules = require("ace/mode/text_highlight_rules").TextHighlightRules;
 
-c_cppHighlightRules = function() {
+var c_cppHighlightRules = function() {
 
     var docComment = new DocCommentHighlightRules();
 

lib/ace/mode/java_highlight_rules.js

@@ -5,7 +5,7 @@ var lang = require("pilot/lang");
 var DocCommentHighlightRules = require("ace/mode/doc_comment_highlight_rules").DocCommentHighlightRules;
 var TextHighlightRules = require("ace/mode/text_highlight_rules").TextHighlightRules;
 
-JavaHighlightRules = function() {
+var JavaHighlightRules = function() {
 
     var docComment = new DocCommentHighlightRules();
 
@@ -22,7 +22,7 @@ JavaHighlightRules = function() {
 	"class|finally|long|strictfp|volatile|" +
 	"const|float|native|super|while").split("|")
     );
-    
+
     var buildinConstants = lang.arrayToMap(
         ("null|Infinity|NaN|undefined").split("|")
     );

lib/ace/mode/javascript_highlight_rules.js

@@ -42,7 +42,7 @@ var lang = require("pilot/lang");
 var DocCommentHighlightRules = require("ace/mode/doc_comment_highlight_rules").DocCommentHighlightRules;
 var TextHighlightRules = require("ace/mode/text_highlight_rules").TextHighlightRules;
 
-JavaScriptHighlightRules = function() {
+var JavaScriptHighlightRules = function() {
 
     var docComment = new DocCommentHighlightRules();
 
@@ -50,11 +50,11 @@ JavaScriptHighlightRules = function() {
         ("break|case|catch|continue|default|delete|do|else|finally|for|function|" +
         "if|in|instanceof|new|return|switch|throw|try|typeof|var|while|with").split("|")
     );
-    
+
     var buildinConstants = lang.arrayToMap(
         ("null|Infinity|NaN|undefined").split("|")
     );
-    
+
     var futureReserved = lang.arrayToMap(
         ("class|enum|extends|super|const|export|import|implements|let|private|" +
         "public|yield|interface|package|protected|static").split("|")

lib/ace/mode/php_highlight_rules.js

@@ -33,7 +33,7 @@
  * the provisions above, a recipient may use your version of this file under
  * the terms of any one of the MPL, the GPL or the LGPL.
  *
- * ***** END LICENSE BLOCK ***** 
+ * ***** END LICENSE BLOCK *****
  */
 
 define(function(require, exports, module) {
@@ -43,7 +43,7 @@ var lang = require("pilot/lang");
 var DocCommentHighlightRules = require("ace/mode/doc_comment_highlight_rules").DocCommentHighlightRules;
 var TextHighlightRules = require("ace/mode/text_highlight_rules").TextHighlightRules;
 
-PhpHighlightRules = function() {
+var PhpHighlightRules = function() {
 
     var docComment = new DocCommentHighlightRules();
 
@@ -443,18 +443,18 @@ PhpHighlightRules = function() {
         'include|include_once|global|goto|if|implements|interface|instanceof|namespace|new|old_function|or|' +
         'private|protected|public|return|require|require_once|static|switch|throw|try|use|var|while|xor').split('|')
     );
-    
+
     var builtinConstants = lang.arrayToMap(
         ('true|false|null|__FILE__|__LINE__|__METHOD__|__FUNCTION__|__CLASS__').split('|')
     );
-    
+
     var builtinVariables = lang.arrayToMap(
         ('$_GLOBALS|$_SERVER|$_GET|$_POST|$_FILES|$_REQUEST|$_SESSION|$_ENV|$_COOKIE|$php_errormsg|$HTTP_RAW_POST_DATA|' +
         '$http_response_header|$argc|$argv').split('|')
     );
-    
+
     var futureReserved = lang.arrayToMap([]);
-    
+
     // regexp must not have capturing parentheses. Use (?:) instead.
     // regexps are ordered -> the first match is used
 
@@ -507,13 +507,13 @@ PhpHighlightRules = function() {
             }, {
                 token : "constant.language", // constants
                 regex : "\\b(?:DEFAULT_INCLUDE_PATH|E_(?:ALL|CO(?:MPILE_(?:ERROR|WARNING)|RE_(?:ERROR|WARNING))|" +
-                        "ERROR|NOTICE|PARSE|STRICT|USER_(?:ERROR|NOTICE|WARNING)|WARNING)|P(?:EAR_(?:EXTENSION_DIR|INSTALL_DIR)|" + 
+                        "ERROR|NOTICE|PARSE|STRICT|USER_(?:ERROR|NOTICE|WARNING)|WARNING)|P(?:EAR_(?:EXTENSION_DIR|INSTALL_DIR)|" +
-                        "HP_(?:BINDIR|CONFIG_FILE_(?:PATH|SCAN_DIR)|DATADIR|E(?:OL|XTENSION_DIR)|INT_(?:MAX|SIZE)|" + 
+                        "HP_(?:BINDIR|CONFIG_FILE_(?:PATH|SCAN_DIR)|DATADIR|E(?:OL|XTENSION_DIR)|INT_(?:MAX|SIZE)|" +
                         "L(?:IBDIR|OCALSTATEDIR)|O(?:S|UTPUT_HANDLER_(?:CONT|END|START))|PREFIX|S(?:API|HLIB_SUFFIX|YSCONFDIR)|" +
                         "VERSION))|__COMPILER_HALT_OFFSET__)\\b"
             }, {
                 token : "constant.language", // constants
-                regex : "\\b(?:A(?:B(?:DAY_(?:1|2|3|4|5|6|7)|MON_(?:1(?:0|1|2|)|2|3|4|5|6|7|8|9))|LT_DIGITS|M_STR|" + 
+                regex : "\\b(?:A(?:B(?:DAY_(?:1|2|3|4|5|6|7)|MON_(?:1(?:0|1|2|)|2|3|4|5|6|7|8|9))|LT_DIGITS|M_STR|" +
                         "SSERT_(?:ACTIVE|BAIL|CALLBACK|QUIET_EVAL|WARNING))|C(?:ASE_(?:LOWER|UPPER)|HAR_MAX|" +
                         "O(?:DESET|NNECTION_(?:ABORTED|NORMAL|TIMEOUT)|UNT_(?:NORMAL|RECURSIVE))|" +
                         "R(?:EDITS_(?:ALL|DOCS|FULLPAGE|G(?:ENERAL|ROUP)|MODULES|QA|SAPI)|NCYSTR|" +

lib/ace/mode/python_highlight_rules.js

@@ -45,7 +45,7 @@ var oop = require("pilot/oop");
 var lang = require("pilot/lang");
 var TextHighlightRules = require("ace/mode/text_highlight_rules").TextHighlightRules;
 
-PythonHighlightRules = function() {
+var PythonHighlightRules = function() {
 
     var keywords = lang.arrayToMap(
         ("and|as|assert|break|class|continue|def|del|elif|else|except|exec|" +

lib/ace/mode/ruby_highlight_rules.js

@@ -42,7 +42,7 @@ var oop = require("pilot/oop");
 var lang = require("pilot/lang");
 var TextHighlightRules = require("ace/mode/text_highlight_rules").TextHighlightRules;
 
-RubyHighlightRules = function() {
+var RubyHighlightRules = function() {
 
     var builtinFunctions = lang.arrayToMap(
         ("abort|Array|at_exit|autoload|binding|block_given?|callcc|caller|catch|chomp|chomp!|chop|chop!|eval|exec|exit|exit!" +
@@ -56,7 +56,7 @@ RubyHighlightRules = function() {
         ("alias|and|BEGIN|begin|break|case|class|def|defined|do|else|elsif|END|end|ensure|__FILE__|finally|for|" +
         "if|in|__LINE__|module|next|not|or|redo|rescue|retry|return|super|then|undef|unless|until|when|while|yield").split("|")
     );
-    
+
     var buildinConstants = lang.arrayToMap(
         ("true|TRUE|false|FALSE|nil|NIL|ARGF|ARGV|DATA|ENV|RUBY_PLATFORM|RUBY_RELEASE_DATE|RUBY_VERSION|STDERR|STDIN|STDOUT|TOPLEVEL_BINDING").split("|")
     );