jyapayne/ace
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Have Status use string constants in place of numbers for easy debugging for now

Browse source
This commit is contained in:
Joe Walker 2010-12-03 15:38:13 +00:00
commit 3dbb9d4c65
1 changed files with 4 additions and 3 deletions
Download patch file Download diff file Expand all files Collapse all files

7
plugins/pilot/lib/types.js
View file

@ -40,6 +40,7 @@ define(function(require, exports, module) {
/** /**
* Some types can detect validity, that is to say they can distinguish between * Some types can detect validity, that is to say they can distinguish between
* valid and invalid values. * valid and invalid values.
* TODO: Change these constants to be numbers for more performance?
*/ */
var Status = { var Status = {
/** /**
@ -47,7 +48,7 @@ var Status = {
* valid. There are a number of failure states, so the best way to check * valid. There are a number of failure states, so the best way to check
* for failure is (x !== Status.VALID) * for failure is (x !== Status.VALID)
*/ */
VALID: 1, VALID: 'VALID',
/** /**
* The conversion process did not work like Status.INVALID, however it was * The conversion process did not work like Status.INVALID, however it was
@ -56,7 +57,7 @@ var Status = {
* yet, just unfinished. * yet, just unfinished.
* @see Status.INVALID * @see Status.INVALID
*/ */
INCOMPLETE: 2, INCOMPLETE: 'INCOMPLETE',
/** /**
* The conversion process did not work, the value should be null and a * The conversion process did not work, the value should be null and a
@ -64,7 +65,7 @@ var Status = {
* values may be available. * values may be available.
* @see Status.INCOMPLETE * @see Status.INCOMPLETE
*/ */
INVALID: 3, INVALID: 'INVALID',
/** /**
* A combined status is the worser of the provided statuses * A combined status is the worser of the provided statuses