jyapayne/ace
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

on session with active placeholder setValue("") crashes the browser

Browse source
This commit is contained in:
nightwing 2012-01-02 21:44:50 +04:00
commit 496446ddfc
1 changed files with 4 additions and 0 deletions
Download patch file Download diff file Expand all files Collapse all files

4
lib/ace/placeholder.js
View file

@ -117,6 +117,8 @@ var PlaceHolder = function(session, length, pos, others, mainClass, othersClass)
var range = delta.range;
if(range.start.row !== range.end.row) return;
if(range.start.row !== this.pos.row) return;
if (this.$updating) return;
this.$updating = true;
var lengthDiff = delta.action === "insertText" ? range.end.column - range.start.column : range.start.column - range.end.column;
if(range.start.column >= this.pos.column && range.start.column <= this.pos.column + this.length + 1) {
@ -169,9 +171,11 @@ var PlaceHolder = function(session, length, pos, others, mainClass, othersClass)
this.others[i]._emit("change", {value: this.others[i]});
}
}
this.$updating = false;
};
this.onCursorChange = function(event) {
if (this.$updating) return;
var pos = this.session.selection.getCursor();
if(pos.row === this.pos.row && pos.column >= this.pos.column && pos.column <= this.pos.column + this.length) {
this.showOtherMarkers();