add unit test for #375

lib/ace/layer/text.js

@@ -352,10 +352,11 @@ var Text = function(parentEl) {
             } else if (c == "\u3000") {
                 // U+3000 is both invisible AND full-width, so must be handled uniquely
                 var classToUse = self.showInvisibles ? "ace_cjk ace_invisible" : "ace_cjk";
+                var space = self.showInvisibles ? self.SPACE_CHAR : "";
                 screenColumn += 1;
                 return "<span class='" + classToUse + "' style='width:" +
                     (self.config.characterWidth * 2) +
-                    "px'>" + c + "</span>";
+                    "px'>" + space + "</span>";
             } else if (c.match(/[\v\f \u00a0\u2000\u2001\u2002\u2003\u2004\u2005\u2006\u2007\u2008\u2009\u200a\u200b\u2028\u2029\u3000]/)) {
                 if (self.showInvisibles) {
                     var space = new Array(c.length+1).join(self.SPACE_CHAR);
@@ -449,7 +450,8 @@ var Text = function(parentEl) {
             else
                 stringBuilder.push("<span class='ace_invisible'>" + this.EOF_CHAR + "</span>");
         }
-        stringBuilder.push("</div>");
+        if (!onlyContents)
+            stringBuilder.push("</div>");
     };
 
     this.$renderLine = function(stringBuilder, row, tokens, onlyContents) {

lib/ace/layer/text_test.js

@@ -0,0 +1,105 @@
+/* ***** BEGIN LICENSE BLOCK *****
+ * Version: MPL 1.1/GPL 2.0/LGPL 2.1
+ *
+ * The contents of this file are subject to the Mozilla Public License Version
+ * 1.1 (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ * http://www.mozilla.org/MPL/
+ *
+ * Software distributed under the License is distributed on an "AS IS" basis,
+ * WITHOUT WARRANTY OF ANY KIND, either express or implied. See the License
+ * for the specific language governing rights and limitations under the
+ * License.
+ *
+ * The Original Code is Ajax.org Code Editor (ACE).
+ *
+ * The Initial Developer of the Original Code is
+ * Ajax.org B.V.
+ * Portions created by the Initial Developer are Copyright (C) 2010
+ * the Initial Developer. All Rights Reserved.
+ *
+ * Contributor(s):
+ *      Fabian Jakobs <fabian AT ajax DOT org>
+ *
+ * Alternatively, the contents of this file may be used under the terms of
+ * either the GNU General Public License Version 2 or later (the "GPL"), or
+ * the GNU Lesser General Public License Version 2.1 or later (the "LGPL"),
+ * in which case the provisions of the GPL or the LGPL are applicable instead
+ * of those above. If you wish to allow use of your version of this file only
+ * under the terms of either the GPL or the LGPL, and not to allow others to
+ * use your version of this file under the terms of the MPL, indicate your
+ * decision by deleting the provisions above and replace them with the notice
+ * and other provisions required by the GPL or the LGPL. If you do not delete
+ * the provisions above, a recipient may use your version of this file under
+ * the terms of any one of the MPL, the GPL or the LGPL.
+ *
+ * ***** END LICENSE BLOCK ***** */
+
+if (typeof process !== "undefined") {
+    require("../../../support/paths");
+    require("ace/test/mockdom");
+}
+
+define(function(require, exports, module) {
+    
+var assert = require("ace/test/assertions");
+var EditSession = require("ace/edit_session").EditSession;
+var TextLayer = require("ace/layer/text").Text;
+var JavaScriptMode = require("ace/mode/javascript").Mode;
+
+module.exports = {
+
+    setUp: function(next) {
+        this.session = new EditSession("");
+        this.session.setMode(new JavaScriptMode());
+        this.textLayer = new TextLayer(document.createElement("div"));
+        this.textLayer.setSession(this.session);
+        this.textLayer.config = {
+            characterWidth: 10,
+            lineHeight: 20
+        };
+        next()
+    },
+
+    "test: render line with hard tabs should render the same as lines with soft tabs" : function() {
+        this.session.setValue("a\ta\ta\t\na   a   a   \n");
+        this.textLayer.$computeTabString();
+        
+        // row with hard tabs
+        var row = 0;
+        var tokens = this.session.getTokens(row, row)[0].tokens;
+        var stringBuilder = [];
+        this.textLayer.$renderLine(stringBuilder, row, tokens);
+        
+        // row with soft tabs
+        row = 1;
+        tokens = this.session.getTokens(row, row)[0].tokens;
+        var stringBuilder2 = [];
+        this.textLayer.$renderLine(stringBuilder2, row, tokens);
+        assert.equal(stringBuilder.join(""), stringBuilder2.join(""));
+    },
+    
+    "test rendering width of ideographic space (U+3000)" : function() {
+        this.session.setValue("\u3000");
+        
+        var tokens = this.session.getTokens(0, 0)[0].tokens;
+        var stringBuilder = [];
+        this.textLayer.$renderLine(stringBuilder, 0, tokens, true);
+        assert.equal(stringBuilder.join(""), "<span class='ace_cjk' style='width:20px'></span>");
+
+        this.textLayer.setShowInvisibles(true);
+        var stringBuilder = [];
+        this.textLayer.$renderLine(stringBuilder, 0, tokens, true);
+        assert.equal(
+            stringBuilder.join(""),
+            "<span class='ace_cjk ace_invisible' style='width:20px'>" + this.textLayer.SPACE_CHAR + "</span>"
+            + "<span class='ace_invisible'>&para;</span>"
+        );
+    }
+};
+
+});
+
+if (typeof module !== "undefined" && module === require.main) {
+    require("asyncjs").test.testcase(module.exports).exec()
+}