From 57662cf8faa8788d96e0b00ae811185051149e89 Mon Sep 17 00:00:00 2001 From: Fabian Jakobs Date: Tue, 13 Dec 2011 13:50:42 +0100 Subject: [PATCH] open folds with single click --- lib/ace/editor.js | 2 + lib/ace/mouse/default_handlers.js | 16 ++------ lib/ace/mouse/fold_handler.js | 61 +++++++++++++++++++++++++++++++ 3 files changed, 66 insertions(+), 13 deletions(-) create mode 100644 lib/ace/mouse/fold_handler.js diff --git a/lib/ace/editor.js b/lib/ace/editor.js index bb4c68b6..c33f4794 100644 --- a/lib/ace/editor.js +++ b/lib/ace/editor.js @@ -47,6 +47,7 @@ var lang = require("./lib/lang"); var useragent = require("./lib/useragent"); var TextInput = require("./keyboard/textinput").TextInput; var MouseHandler = require("./mouse/mouse_handler").MouseHandler; +var FoldHandler = require("./mouse/fold_handler").FoldHandler; //var TouchHandler = require("./touch_handler").TouchHandler; var KeyBinding = require("./keyboard/keybinding").KeyBinding; var EditSession = require("./edit_session").EditSession; @@ -69,6 +70,7 @@ var Editor = function(renderer, session) { //this.$mouseHandler = new TouchHandler(this); } else { this.$mouseHandler = new MouseHandler(this); + new FoldHandler(this); } this.$blockScrolling = 0; diff --git a/lib/ace/mouse/default_handlers.js b/lib/ace/mouse/default_handlers.js index 6781674e..9a4450a0 100644 --- a/lib/ace/mouse/default_handlers.js +++ b/lib/ace/mouse/default_handlers.js @@ -254,19 +254,9 @@ function DefaultHandlers(editor) { var pos = ev.getDocumentPosition(); var editor = this.editor; - // If the user dclicked on a fold, then expand it. - var fold = editor.session.getFoldAt(pos.row, pos.column, 1); - if (fold) { - if (ev.getAccelKey()) - editor.session.removeFold(fold); - else - editor.session.expandFold(fold); - } - else { - editor.moveCursorToPosition(pos); - editor.selection.selectWord(); - this.$clickSelection = editor.getSelectionRange(); - } + editor.moveCursorToPosition(pos); + editor.selection.selectWord(); + this.$clickSelection = editor.getSelectionRange(); }; this.onTripleClick = function(ev) { diff --git a/lib/ace/mouse/fold_handler.js b/lib/ace/mouse/fold_handler.js new file mode 100644 index 00000000..6afb017e --- /dev/null +++ b/lib/ace/mouse/fold_handler.js @@ -0,0 +1,61 @@ +/* vim:ts=4:sts=4:sw=4: + * ***** BEGIN LICENSE BLOCK ***** + * Version: MPL 1.1/GPL 2.0/LGPL 2.1 + * + * The contents of this file are subject to the Mozilla Public License Version + * 1.1 (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * http://www.mozilla.org/MPL/ + * + * Software distributed under the License is distributed on an "AS IS" basis, + * WITHOUT WARRANTY OF ANY KIND, either express or implied. See the License + * for the specific language governing rights and limitations under the + * License. + * + * The Original Code is Ajax.org Code Editor (ACE). + * + * The Initial Developer of the Original Code is + * Ajax.org B.V. + * Portions created by the Initial Developer are Copyright (C) 2010 + * the Initial Developer. All Rights Reserved. + * + * Contributor(s): + * Fabian Jakobs + * Mike de Boer + * + * Alternatively, the contents of this file may be used under the terms of + * either the GNU General Public License Version 2 or later (the "GPL"), or + * the GNU Lesser General Public License Version 2.1 or later (the "LGPL"), + * in which case the provisions of the GPL or the LGPL are applicable instead + * of those above. If you wish to allow use of your version of this file only + * under the terms of either the GPL or the LGPL, and not to allow others to + * use your version of this file under the terms of the MPL, indicate your + * decision by deleting the provisions above and replace them with the notice + * and other provisions required by the GPL or the LGPL. If you do not delete + * the provisions above, a recipient may use your version of this file under + * the terms of any one of the MPL, the GPL or the LGPL. + * + * ***** END LICENSE BLOCK ***** */ + +define(function(require, exports, module) { + +function FoldHandler(editor) { + editor.on("click", function(ev) { + var pos = ev.getDocumentPosition(); + + // If the user dclicked on a fold, then expand it. + var fold = editor.session.getFoldAt(pos.row, pos.column, 1); + if (fold) { + if (ev.getAccelKey()) + editor.session.removeFold(fold); + else + editor.session.expandFold(fold); + + ev.preventDefault(); + } + }); +} + +exports.FoldHandler = FoldHandler; + +}); \ No newline at end of file