From ab1b62fbb7a22a5a9d733a58959eb2bdb0313988 Mon Sep 17 00:00:00 2001 From: Derk-Jan Hartman Date: Thu, 16 Jan 2014 14:10:12 +0100 Subject: [PATCH 1/2] Lua uses self, not this There is no 'this' in lua. There is however 'self' a predefined parameter when using colon syntax for calling a function. http://www.lua.org/pil/16.html --- lib/ace/mode/lua_highlight_rules.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/ace/mode/lua_highlight_rules.js b/lib/ace/mode/lua_highlight_rules.js index 5eb969d3..faa37bc2 100644 --- a/lib/ace/mode/lua_highlight_rules.js +++ b/lib/ace/mode/lua_highlight_rules.js @@ -83,7 +83,7 @@ var LuaHighlightRules = function() { "constant.library": stdLibaries, "constant.language": builtinConstants, "invalid.illegal": futureReserved, - "variable.language": "this" + "variable.language": "self" }, "identifier"); var decimalInteger = "(?:(?:[1-9]\\d*)|(?:0))"; From 93c14b1b3157c037423a235f233a0dc89c274a29 Mon Sep 17 00:00:00 2001 From: Derk-Jan Hartman Date: Fri, 17 Jan 2014 11:54:51 +0100 Subject: [PATCH 2/2] Update testcase for lua self --- lib/ace/mode/_test/tokens_lua.json | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/lib/ace/mode/_test/tokens_lua.json b/lib/ace/mode/_test/tokens_lua.json index 276b3ffc..3fde966d 100644 --- a/lib/ace/mode/_test/tokens_lua.json +++ b/lib/ace/mode/_test/tokens_lua.json @@ -201,7 +201,7 @@ ["keyword.operator","="], ["keyword","function"], ["paren.lparen","("], - ["identifier","self"], + ["variable.language","self"], ["text",", "], ["identifier","other"], ["paren.rparen",")"] @@ -266,7 +266,7 @@ ["text"," "], ["keyword","return"], ["text"," "], - ["identifier","self"], + ["variable.language","self"], ["keyword.operator",":"], ["support.function","format"], ["paren.lparen","("], @@ -345,4 +345,4 @@ ["text"," "], ["comment","--[[ blah ]]"], ["paren.rparen",")"] -]] \ No newline at end of file +]]