From 633293ee5ef09bce1878c5473ea024f2cd35110d Mon Sep 17 00:00:00 2001 From: Fabian Jakobs Date: Wed, 15 Dec 2010 15:41:08 +0100 Subject: [PATCH] fix character size measurement --- lib/ace/layer/text.js | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/lib/ace/layer/text.js b/lib/ace/layer/text.js index 7af4c7aa..98ff7bfc 100644 --- a/lib/ace/layer/text.js +++ b/lib/ace/layer/text.js @@ -92,6 +92,7 @@ var Text = function(parentEl) { }, this.$measureSizes = function() { + var n = 1000; if (!this.$measureNode) { var measureNode = this.$measureNode = document.createElement("div"); var style = measureNode.style; @@ -107,12 +108,11 @@ var Text = function(parentEl) { // in FF 3.6 monospace fonts can have a fixed sub pixel width. // that's why we have to measure many characters // Note: characterWidth can be a float! - var n = 1000; measureNode.innerHTML = lang.stringRepeat("Xy", n); document.body.insertBefore(measureNode, document.body.firstChild); } - var style = this.$measureNode; + var style = this.$measureNode.style; for (var prop in this.$fontStyles) { var value = dom.computedStyle(this.element, prop); style[prop] = value; @@ -122,7 +122,6 @@ var Text = function(parentEl) { height: this.$measureNode.offsetHeight, width: this.$measureNode.offsetWidth / (n * 2) }; - return size; };