Merge pull request #2267 from ajaxorg/fix/various

Fix various small issues

lib/ace/config_test.js

@@ -118,11 +118,18 @@ module.exports = {
         o.setOption("initialValue", 7);
         assert.equal(o.getOption("opt2"), 7);
         
+        config.setDefaultValues("test_object", {
+            opt1: 1,
+            forwarded: 2
+        });
+        config.resetOptions(o);
+        assert.equal(o.getOption("opt1"), 1);
+        assert.equal(o.getOption("forwarded"), 2);
     }
 };
 
 });
 
 if (typeof module !== "undefined" && module === require.main) {
-    require("asyncjs").test.testcase(module.exports).exec()
+    require("asyncjs").test.testcase(module.exports).exec();
 }

lib/ace/editor.js

@@ -539,12 +539,15 @@ var Editor = function(renderer, session) {
             var iterator = new TokenIterator(self.session, pos.row, pos.column);
             var token = iterator.getCurrentToken();
             
-            if (!token || token.type.indexOf('tag-name') === -1) {
+            if (!token || !/\b(?:tag-open|tag-name)/.test(token.type)) {
                 session.removeMarker(session.$tagHighlight);
                 session.$tagHighlight = null;
                 return;
             }
             
+            if (token.type.indexOf("tag-open") != -1)
+                token = iterator.stepForward();
+
             var tag = token.value;
             var depth = 0;
             var prevToken = iterator.stepBackward();

lib/ace/keyboard/textinput.js

@@ -45,10 +45,10 @@ var TextInput = function(parentNode, host) {
     if (useragent.isTouchPad)
         text.setAttribute("x-palm-disable-auto-cap", true);
 
-    text.wrap = "off";
+    text.setAttribute("wrap", "off");
-    text.autocorrect = "off";
+    text.setAttribute("autocorrect", "off");
-    text.autocapitalize = "off";
+    text.setAttribute("autocapitalize", "off");
-    text.spellcheck = false;
+    text.setAttribute("spellcheck", false);
 
     text.style.opacity = "0";
     if (useragent.isOldIE) text.style.top = "-100px";

lib/ace/lib/app_config.js

@@ -31,7 +31,6 @@
 define(function(require, exports, module) {
 "no use strict";
 
-var lang = require("./lang");
 var oop = require("./oop");
 var EventEmitter = require("./event_emitter").EventEmitter;
 
@@ -91,7 +90,7 @@ function reportError(msg, data) {
     if (typeof console == "object" && console.error)
         console.error(e);
     setTimeout(function() { throw e; });
-};
+}
 
 var AppConfig = function() {
     this.$defaultOptions = {};
@@ -145,7 +144,7 @@ var AppConfig = function() {
     this.setDefaultValues = function(path, optionHash) {
         Object.keys(optionHash).forEach(function(key) {
             this.setDefaultValue(path, key, optionHash[key]);
-        });
+        }, this);
     };
     
     this.warn = warn;

lib/ace/mouse/multi_select_handler.js

@@ -151,6 +151,7 @@ function onMouseDown(e) {
                 return;
             screenCursor = newCursor;
             
+            editor.$blockScrolling++;
             editor.selection.moveToPosition(cursor);
             editor.renderer.scrollCursorIntoView();
 
@@ -160,8 +161,9 @@ function onMouseDown(e) {
                 rectSel[0] = editor.$mouseHandler.$clickSelection.clone();
             rectSel.forEach(editor.addSelectionMarker, editor);
             editor.updateSelectionMarkers();
+            editor.$blockScrolling--;
         };
-        
+        editor.$blockScrolling++;
         if (isMultiSelect && !accel) {
             selection.toSingleRange();
         } else if (!isMultiSelect && accel) {
@@ -173,6 +175,7 @@ function onMouseDown(e) {
             screenAnchor = session.documentToScreenPosition(selection.lead);            
         else
             selection.moveToPosition(pos);
+        editor.$blockScrolling--;
         
         screenCursor = {row: -1, column: -1};