jyapayne/ace
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

addEventListener was breaking old browsers

Browse source
This commit is contained in:
nightwing 2012-04-29 14:29:33 +04:00
commit 9ae7bc0c04
2 changed files with 8 additions and 7 deletions
Download patch file Download diff file Expand all files Collapse all files

8
demo/kitchen-sink/demo.js
View file

@ -301,7 +301,8 @@ split.on("focus", function(editor) {
}); });
env.split = split; env.split = split;
window.env = env; window.env = env;
window.ace = env.editor; window.editor = window.ace = env.editor;
env.editor.setAnimatedScroll(true);
var docEl = document.getElementById("doc"); var docEl = document.getElementById("doc");
var modeEl = document.getElementById("mode"); var modeEl = document.getElementById("mode");
@ -395,13 +396,13 @@ function saveOption(el, val) {
} }
} }
themeEl.addEventListener("mouseover", function(e){ event.addListener(themeEl, "mouseover", function(e){
this.desiredValue = e.target.value; this.desiredValue = e.target.value;
if (!this.$timer) if (!this.$timer)
this.$timer = setTimeout(this.updateTheme); this.$timer = setTimeout(this.updateTheme);
}) })
themeEl.addEventListener("mouseout", function(e){ event.addListener(themeEl, "mouseout", function(e){
this.desiredValue = null; this.desiredValue = null;
if (!this.$timer) if (!this.$timer)
this.$timer = setTimeout(this.updateTheme, 20); this.$timer = setTimeout(this.updateTheme, 20);
@ -486,7 +487,6 @@ bindCheckbox("show_hscroll", function(checked) {
env.editor.renderer.setHScrollBarAlwaysVisible(checked); env.editor.renderer.setHScrollBarAlwaysVisible(checked);
}); });
env.editor.setAnimatedScroll(true);
bindCheckbox("animate_scroll", function(checked) { bindCheckbox("animate_scroll", function(checked) {
env.editor.setAnimatedScroll(checked); env.editor.setAnimatedScroll(checked);
}); });

7
lib/ace/multi_select.js
View file

@ -42,6 +42,7 @@ var RangeList = require("./range_list").RangeList;
var Range = require("./range").Range; var Range = require("./range").Range;
var Selection = require("./selection").Selection; var Selection = require("./selection").Selection;
var onMouseDown = require("./mouse/multi_select_handler").onMouseDown; var onMouseDown = require("./mouse/multi_select_handler").onMouseDown;
var event = require("./lib/event");
exports.commands = require("./commands/multi_select_commands"); exports.commands = require("./commands/multi_select_commands");
// Todo: session.find or editor.findVolatile that returns range // Todo: session.find or editor.findVolatile that returns range
@ -734,7 +735,7 @@ function addAltCursorListeners(editor){
var el = editor.textInput.getElement(); var el = editor.textInput.getElement();
var altCursor = false; var altCursor = false;
var contentEl = editor.renderer.content; var contentEl = editor.renderer.content;
el.addEventListener("keydown", function(e) { event.addListener(el, "keydown", function(e) {
if (e.keyCode == 18 && !(e.ctrlKey || e.shiftKey || e.metaKey)) { if (e.keyCode == 18 && !(e.ctrlKey || e.shiftKey || e.metaKey)) {
if (!altCursor) { if (!altCursor) {
contentEl.style.cursor = "crosshair"; contentEl.style.cursor = "crosshair";
@ -745,8 +746,8 @@ function addAltCursorListeners(editor){
} }
}); });
el.addEventListener("keyup", reset); event.addListener(el, "keyup", reset);
el.addEventListener("blur", reset); event.addListener(el, "blur", reset);
function reset() { function reset() {
if (altCursor) { if (altCursor) {
contentEl.style.cursor = ""; contentEl.style.cursor = "";