jyapayne/ace
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Merge pull request #2022 from ajaxorg/performance

Browse source 
do not use setInnerHTML since it isn't faster on new browsers
This commit is contained in:
Ruben Daniels 2014-07-03 13:53:19 +02:00
commit c3bb709318
3 changed files with 4 additions and 4 deletions
Download patch file Download diff file Expand all files Collapse all files

2
demo/kitchen-sink/demo.js
View file

@ -592,7 +592,7 @@ env.editSnippets = function() {
require("ace/ext/language_tools"); require("ace/ext/language_tools");
env.editor.setOptions({ env.editor.setOptions({
enableBasicAutocompletion: true, enableBasicAutocompletion: true,
enableLiveAutocompletion: true, enableLiveAutocompletion: false,
enableSnippets: true enableSnippets: true
}); });

2
lib/ace/layer/marker.js
View file

@ -93,7 +93,7 @@ var Marker = function(parentEl) {
this.drawSingleLineMarker(html, range, marker.clazz + " ace_start", config); this.drawSingleLineMarker(html, range, marker.clazz + " ace_start", config);
} }
} }
this.element = dom.setInnerHtml(this.element, html.join("")); this.element.innerHTML = html.join("");
}; };
this.$getTop = function(row, layerConfig) { this.$getTop = function(row, layerConfig) {

4
lib/ace/layer/text.js
View file

@ -203,7 +203,7 @@ var Text = function(parentEl) {
html, row, !this.$useLineGroups(), row == foldStart ? foldLine : false html, row, !this.$useLineGroups(), row == foldStart ? foldLine : false
); );
lineElement.style.height = config.lineHeight * this.session.getRowLength(row) + "px"; lineElement.style.height = config.lineHeight * this.session.getRowLength(row) + "px";
dom.setInnerHtml(lineElement, html.join("")); lineElement.innerHTML = html.join("");
} }
row++; row++;
} }
@ -310,7 +310,7 @@ var Text = function(parentEl) {
row++; row++;
} }
this.element = dom.setInnerHtml(this.element, html.join("")); this.element.innerHTML = html.join("");
}; };
this.$textToken = { this.$textToken = {