From c4012ebd461b5809f50273eaa7da7e59776438e1 Mon Sep 17 00:00:00 2001 From: Aaron O'Mullan Date: Tue, 28 Jan 2014 02:14:23 +0100 Subject: [PATCH] Don't autoInsert with auto magic completer This caused completions to be inserted without ever being shown, if they were the only completion for the prefix entered. --- lib/ace/ext/language_tools.js | 13 ++++++++++++- 1 file changed, 12 insertions(+), 1 deletion(-) diff --git a/lib/ace/ext/language_tools.js b/lib/ace/ext/language_tools.js index b739eabe..b505fcfa 100644 --- a/lib/ace/ext/language_tools.js +++ b/lib/ace/ext/language_tools.js @@ -145,7 +145,18 @@ var onChangeAutocomplete = function(e, editor) { // Only autocomplete if there's a prefix that can be matched if(prefix !== '' && !(hasCompleter)) { - Autocomplete.startCommand.exec(editor); + if (!editor.completer) { + // Create new autocompleter + editor.completer = new Autocomplete(); + + // Disable autoInsert + editor.completer.autoInsert = false; + } + + editor.completer.showPopup(editor); + // needed for firefox on mac + editor.completer.cancelContextMenu(); + } else if(prefix === '' && hasCompleter) { // When the prefix is empty // close the autocomplete dialog