jyapayne/ace
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Merge pull request #824 from miketaylr/opera_keyboardevent

Browse source 
Add "KeyboardEvent" in window check for old Opera.
This commit is contained in:
Harutyun Amirjanyan 2012-06-30 00:03:15 -07:00
commit c66d16c109
1 changed files with 2 additions and 2 deletions
Download patch file Download diff file Expand all files Collapse all files

4
lib/ace/lib/event.js
View file

@ -227,7 +227,7 @@ exports.addMultiMouseDownListener = function(el, timeouts, eventHandler, callbac
function normalizeCommandKeys(callback, e, keyCode) { function normalizeCommandKeys(callback, e, keyCode) {
var hashId = 0; var hashId = 0;
if (useragent.isOpera && useragent.isMac) { if ((useragent.isOpera && !("KeyboardEvent" in window)) && useragent.isMac) {
hashId = 0 | (e.metaKey ? 1 : 0) | (e.altKey ? 2 : 0) hashId = 0 | (e.metaKey ? 1 : 0) | (e.altKey ? 2 : 0)
| (e.shiftKey ? 4 : 0) | (e.ctrlKey ? 8 : 0); | (e.shiftKey ? 4 : 0) | (e.ctrlKey ? 8 : 0);
} else { } else {
@ -268,7 +268,7 @@ function normalizeCommandKeys(callback, e, keyCode) {
exports.addCommandKeyListener = function(el, callback) { exports.addCommandKeyListener = function(el, callback) {
var addListener = exports.addListener; var addListener = exports.addListener;
if (useragent.isOldGecko || useragent.isOpera) { if (useragent.isOldGecko || (useragent.isOpera && !("KeyboardEvent" in window))) {
// Old versions of Gecko aka. Firefox < 4.0 didn't repeat the keydown // Old versions of Gecko aka. Firefox < 4.0 didn't repeat the keydown
// event if the user pressed the key for a longer time. Instead, the // event if the user pressed the key for a longer time. Instead, the
// keydown event was fired once and later on only the keypress event. // keydown event was fired once and later on only the keypress event.