jyapayne/ace
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Fix bug and clarify async autocomplete result gathering

Browse source 
@SamyPesse’s “left: total - (i + 1)” was flawed because it only would
work if all completers were async
This commit is contained in:
Aaron O'Mullan 2014-02-08 00:50:50 +01:00
commit cbbbf1c539
1 changed files with 3 additions and 2 deletions
Download patch file Download diff file Expand all files Collapse all files

5
lib/ace/autocomplete.js
View file

@ -206,7 +206,7 @@ var Autocomplete = function() {
callback(null, { callback(null, {
prefix: prefix, prefix: prefix,
matches: matches, matches: matches,
left: total - (i + 1) finished: (--total === 0)
}); });
}); });
}); });
@ -255,8 +255,9 @@ var Autocomplete = function() {
// Save current gatherCompletions session, session is close when a match is insert // Save current gatherCompletions session, session is close when a match is insert
var _id = this.gatherCompletionsId; var _id = this.gatherCompletionsId;
this.gatherCompletions(this.editor, function(err, results) { this.gatherCompletions(this.editor, function(err, results) {
// Only detach if result gathering is finished
var doDetach = function() { var doDetach = function() {
if (results.left > 0) return; if (!results.finished) return;
return this.detach(); return this.detach();
}.bind(this); }.bind(this);