From d2a783f824ee749f3d9ac078679f1558b6dede39 Mon Sep 17 00:00:00 2001 From: Fabian Jakobs Date: Mon, 19 Dec 2011 12:03:57 +0100 Subject: [PATCH] use _emit iso _dispatchEvent --- lib/ace/anchor.js | 2 +- lib/ace/background_tokenizer.js | 2 +- lib/ace/document.js | 12 +++++----- lib/ace/edit_session.js | 38 +++++++++++++++---------------- lib/ace/edit_session/folding.js | 4 ++-- lib/ace/layer/text.js | 2 +- lib/ace/lib/event_emitter_test.js | 2 +- lib/ace/mouse/mouse_handler.js | 6 ++--- lib/ace/placeholder.js | 8 +++---- lib/ace/scrollbar.js | 2 +- lib/ace/selection.js | 10 ++++---- lib/ace/worker/worker.js | 8 +++---- lib/ace/worker/worker_client.js | 8 +++---- 13 files changed, 52 insertions(+), 52 deletions(-) diff --git a/lib/ace/anchor.js b/lib/ace/anchor.js index 56406b4a..22903cf0 100644 --- a/lib/ace/anchor.js +++ b/lib/ace/anchor.js @@ -155,7 +155,7 @@ var Anchor = exports.Anchor = function(doc, row, column) { this.row = pos.row; this.column = pos.column; - this._dispatchEvent("change", { + this._emit("change", { old: old, value: pos }); diff --git a/lib/ace/background_tokenizer.js b/lib/ace/background_tokenizer.js index e5fe73bd..a9c6eb5a 100644 --- a/lib/ace/background_tokenizer.js +++ b/lib/ace/background_tokenizer.js @@ -100,7 +100,7 @@ var BackgroundTokenizer = function(tokenizer, editor) { first: firstRow, last: lastRow }; - this._dispatchEvent("update", {data: data}); + this._emit("update", {data: data}); }; this.start = function(startRow) { diff --git a/lib/ace/document.js b/lib/ace/document.js index 81ffe20d..a92f6753 100644 --- a/lib/ace/document.js +++ b/lib/ace/document.js @@ -207,7 +207,7 @@ var Document = function(text) { range: range, lines: lines }; - this._dispatchEvent("change", { data: delta }); + this._emit("change", { data: delta }); return range.end; }; @@ -228,7 +228,7 @@ var Document = function(text) { range: Range.fromPoints(position, end), text: this.getNewLineCharacter() }; - this._dispatchEvent("change", { data: delta }); + this._emit("change", { data: delta }); return end; }; @@ -252,7 +252,7 @@ var Document = function(text) { range: Range.fromPoints(position, end), text: text }; - this._dispatchEvent("change", { data: delta }); + this._emit("change", { data: delta }); return end; }; @@ -304,7 +304,7 @@ var Document = function(text) { range: range, text: removed }; - this._dispatchEvent("change", { data: delta }); + this._emit("change", { data: delta }); return range.start; }; @@ -325,7 +325,7 @@ var Document = function(text) { nl: this.getNewLineCharacter(), lines: removed }; - this._dispatchEvent("change", { data: delta }); + this._emit("change", { data: delta }); return removed; }; @@ -343,7 +343,7 @@ var Document = function(text) { range: range, text: this.getNewLineCharacter() }; - this._dispatchEvent("change", { data: delta }); + this._emit("change", { data: delta }); }; this.replace = function(range, text) { diff --git a/lib/ace/edit_session.js b/lib/ace/edit_session.js index cbdcc1c9..40ffcbcf 100644 --- a/lib/ace/edit_session.js +++ b/lib/ace/edit_session.js @@ -142,7 +142,7 @@ var EditSession = function(text, mode) { } this.bgTokenizer.start(delta.range.start.row); - this._dispatchEvent("change", e); + this._emit("change", e); }; this.setValue = function(text) { @@ -275,7 +275,7 @@ var EditSession = function(text, mode) { this.$modified = true; this.$tabSize = tabSize; - this._dispatchEvent("changeTabSize"); + this._emit("changeTabSize"); }; this.getTabSize = function() { @@ -291,7 +291,7 @@ var EditSession = function(text, mode) { if (this.$overwrite == overwrite) return; this.$overwrite = overwrite; - this._dispatchEvent("changeOverwrite"); + this._emit("changeOverwrite"); }; this.getOverwrite = function() { @@ -311,22 +311,22 @@ var EditSession = function(text, mode) { for (var i=0; i= this.pos.column && pos.column <= this.pos.column + this.length) { this.showOtherMarkers(); - this._dispatchEvent("cursorEnter", event); + this._emit("cursorEnter", event); } else { this.hideOtherMarkers(); - this._dispatchEvent("cursorLeave", event); + this._emit("cursorLeave", event); } }; diff --git a/lib/ace/scrollbar.js b/lib/ace/scrollbar.js index 64c418df..715d6a3f 100644 --- a/lib/ace/scrollbar.js +++ b/lib/ace/scrollbar.js @@ -67,7 +67,7 @@ var ScrollBar = function(parent) { oop.implement(this, EventEmitter); this.onScroll = function() { - this._dispatchEvent("scroll", {data: this.element.scrollTop}); + this._emit("scroll", {data: this.element.scrollTop}); }; this.getWidth = function() { diff --git a/lib/ace/selection.js b/lib/ace/selection.js index 88ba70ef..3939a0b7 100644 --- a/lib/ace/selection.js +++ b/lib/ace/selection.js @@ -60,16 +60,16 @@ var Selection = function(session) { var _self = this; this.selectionLead.on("change", function(e) { - _self._dispatchEvent("changeCursor"); + _self._emit("changeCursor"); if (!_self.$isEmpty) - _self._dispatchEvent("changeSelection"); + _self._emit("changeSelection"); if (!_self.$preventUpdateDesiredColumnOnChange && e.old.column != e.value.column) _self.$updateDesiredColumn(); }); this.selectionAnchor.on("change", function() { if (!_self.$isEmpty) - _self._dispatchEvent("changeSelection"); + _self._emit("changeSelection"); }); }; @@ -101,7 +101,7 @@ var Selection = function(session) { if (this.$isEmpty) { this.$isEmpty = false; - this._dispatchEvent("changeSelection"); + this._emit("changeSelection"); } }; @@ -161,7 +161,7 @@ var Selection = function(session) { this.clearSelection = function() { if (!this.$isEmpty) { this.$isEmpty = true; - this._dispatchEvent("changeSelection"); + this._emit("changeSelection"); } }; diff --git a/lib/ace/worker/worker.js b/lib/ace/worker/worker.js index ed8f0fd0..2302971a 100644 --- a/lib/ace/worker/worker.js +++ b/lib/ace/worker/worker.js @@ -41,7 +41,7 @@ var require = function(parentId, id) { var chunks = id.split("/"); chunks[0] = require.tlns[chunks[0]] || chunks[0]; - path = chunks.join("/") + ".js"; + var path = chunks.join("/") + ".js"; require.id = id; importScripts(path); @@ -64,7 +64,7 @@ var define = function(id, deps, factory) { var req = function(deps, factory) { return require(id, deps, factory); - } + }; require.modules[id] = { factory: function() { @@ -118,7 +118,7 @@ function initSender() { var main; var sender; -onmessage = function(e) { +var onmessage = function(e) { var msg = e.data; if (msg.command) { main[msg.command].apply(main, msg.args); @@ -131,6 +131,6 @@ onmessage = function(e) { main = new clazz(sender); } else if (msg.event && sender) { - sender._dispatchEvent(msg.event, msg.data); + sender._emit(msg.event, msg.data); } }; diff --git a/lib/ace/worker/worker_client.js b/lib/ace/worker/worker_client.js index 2fbfd43e..0a7b1bfb 100644 --- a/lib/ace/worker/worker_client.js +++ b/lib/ace/worker/worker_client.js @@ -46,11 +46,11 @@ var WorkerClient = function(topLevelNamespaces, packagedJs, module, classname) { if (window.require.packaged) { var base = this.$guessBasePath(); - var worker = this.$worker = new Worker(base + packagedJs); + this.$worker = new Worker(base + packagedJs); } else { var workerUrl = this.$normalizePath(require.nameToUrl("ace/worker/worker", null, "_")); - var worker = this.$worker = new Worker(workerUrl); + this.$worker = new Worker(workerUrl); var tlns = {}; for (var i=0; i