jyapayne/ace
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

fix caching of foldWidgets

Browse source
This commit is contained in:
nightwing 2011-12-01 23:19:42 +04:00
commit d9f3eff921
3 changed files with 5 additions and 3 deletions
Download patch file Download diff file Expand all files Collapse all files

3
lib/ace/layer/gutter.js
View file

@ -129,7 +129,8 @@ var Gutter = function(parentEl) {
if (foldWidgets) { if (foldWidgets) {
var c = foldWidgets[i]; var c = foldWidgets[i];
if (!c) // check if cached value is invalidated and we need to recompute
if (c == null)
c = foldWidgets[i] = this.session.getFoldWidget(i); c = foldWidgets[i] = this.session.getFoldWidget(i);
if (c) if (c)
html.push( html.push(

1
lib/ace/mode/folding/fold_mode.js
View file

@ -48,6 +48,7 @@ var FoldMode = exports.FoldMode = function() {};
this.foldingStartMarker = null; this.foldingStartMarker = null;
this.foldingStopMarker = null; this.foldingStopMarker = null;
// must return "" if there's no fold, to enable caching
this.getFoldWidget = function(session, row) { this.getFoldWidget = function(session, row) {
if (this.foldingStartMarker) { if (this.foldingStartMarker) {
if (this.foldingStopMarker) if (this.foldingStopMarker)

4
lib/ace/mode/folding/xml.js
View file

@ -66,13 +66,13 @@ oop.inherits(FoldMode, BaseFoldMode);
var fold = tags[0]; var fold = tags[0];
if (!fold || this.voidElements[fold]) if (!fold || this.voidElements[fold])
return; return "";
if (fold.charAt(0) == "/") if (fold.charAt(0) == "/")
return "end"; return "end";
if (tags.indexOf("/" + fold) !== -1) if (tags.indexOf("/" + fold) !== -1)
return; return "";
return "start"; return "start";
}; };