remove listeners when worker is terminated

fixes bug with workers on firefox 8.0a

lib/ace/mode/coffee.js

@@ -97,17 +97,8 @@ oop.inherits(Mode, TextMode);
     };
     
     this.createWorker = function(session) {
-        var doc = session.getDocument();
         var worker = new WorkerClient(["ace", "pilot"], "worker-coffee.js", "ace/mode/coffee_worker", "Worker");
-        worker.call("setValue", [doc.getValue()]);
+        worker.attachToDocument(session.getDocument());
-        
-        doc.on("change", function(e) {
-            e.range = {
-                start: e.data.range.start,
-                end: e.data.range.end
-            };
-            worker.emit("change", e);
-        });
         
         worker.on("error", function(e) {
             session.setAnnotations([e.data]);

lib/ace/mode/css.js

@@ -78,17 +78,8 @@ oop.inherits(Mode, TextMode);
     };
     
     this.createWorker = function(session) {
-        var doc = session.getDocument();
         var worker = new WorkerClient(["ace", "pilot"], "worker-css.js", "ace/mode/css_worker", "Worker");
-        worker.call("setValue", [doc.getValue()]);
+        worker.attachToDocument(session.getDocument());
-        
-        doc.on("change", function(e) {
-            e.range = {
-                start: e.data.range.start,
-                end: e.data.range.end
-            };
-            worker.emit("change", e);
-        });
         
         worker.on("csslint", function(e) {
             var errors = [];

lib/ace/mode/javascript.js

@@ -125,17 +125,8 @@ oop.inherits(Mode, TextMode);
     };
     
     this.createWorker = function(session) {
-        var doc = session.getDocument();
         var worker = new WorkerClient(["ace", "pilot"], "worker-javascript.js", "ace/mode/javascript_worker", "JavaScriptWorker");
-        worker.call("setValue", [doc.getValue()]);
+		worker.attachToDocument(session.getDocument());
-        
-        doc.on("change", function(e) {
-            e.range = {
-                start: e.data.range.start,
-                end: e.data.range.end
-            };
-            worker.emit("change", e);
-        });
             
         worker.on("jslint", function(results) {
             var errors = [];

lib/ace/worker/worker_client.js

@@ -42,7 +42,7 @@ var EventEmitter = require("pilot/event_emitter").EventEmitter;
 
 var WorkerClient = function(topLevelNamespaces, packagedJs, module, classname) {
 
-    this.callbacks = [];
+    this.changeListener = this.changeListener.bind(this);
 
     if (require.packaged) {
         var base = this.$guessBasePath();
@@ -138,6 +138,9 @@ var WorkerClient = function(topLevelNamespaces, packagedJs, module, classname) {
     this.terminate = function() {
         this._dispatchEvent("terminate", {});
         this.$worker.terminate();
+        this.$worker = null;
+		this.$doc.removeEventListener("change", this.changeListener);
+		this.$doc = null;
     };
 
     this.send = function(cmd, args) {
@@ -157,9 +160,29 @@ var WorkerClient = function(topLevelNamespaces, packagedJs, module, classname) {
         try {
             this.$worker.postMessage({event: event, data: data});
         }
-        catch(ex) {}
+        catch(ex) {
+            console.log("no worker");
+            console.trace();
+        }
     };
 	
+	this.attachToDocument = function(doc) {
+		if(this.$doc)
+			this.terminate();
+
+		this.$doc = doc;
+		this.call("setValue", [doc.getValue()]);        
+        doc.on("change", this.changeListener);
+	};
+	
+	this.changeListener = function(e) {
+		e.range = {
+			start: e.data.range.start,
+			end: e.data.range.end
+		};
+		this.emit("change", e);
+	};
+
 }).call(WorkerClient.prototype);
 
 exports.WorkerClient = WorkerClient;