jyapayne/anbox
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

dbus: remove private unused field type_

Browse source 
This commit removes the private unused field type_ from anbox::dbus::Bus
and promotes -Wunused-private-field back to error level on clang.
This commit is contained in:
Gabriel Rauter 2018-09-04 19:24:52 +02:00
commit 3c1d7e6149
3 changed files with 1 additions and 5 deletions
Download patch file Download diff file Expand all files Collapse all files

1
CMakeLists.txt
View file

@ -25,7 +25,6 @@ set(EXTRA_C_WARNINGS "-Wcast-align -Wcast-qual -Wformat -Wredundant-decls -Wswit
set(EXTRA_CXX_WARNINGS "-Wnon-virtual-dtor -Wold-style-cast") set(EXTRA_CXX_WARNINGS "-Wnon-virtual-dtor -Wold-style-cast")
if("${CMAKE_CXX_COMPILER_ID}" STREQUAL "Clang") if("${CMAKE_CXX_COMPILER_ID}" STREQUAL "Clang")
set(EXTRA_CXX_WARNINGS "${EXTRA_CXX_WARNINGS} -Wno-error=unused-private-field")
set(EXTRA_CXX_WARNINGS "${EXTRA_CXX_WARNINGS} -Wno-error=unused-const-variable") set(EXTRA_CXX_WARNINGS "${EXTRA_CXX_WARNINGS} -Wno-error=unused-const-variable")
set(EXTRA_CXX_WARNINGS "${EXTRA_CXX_WARNINGS} -Wno-error=unused-lambda-capture") set(EXTRA_CXX_WARNINGS "${EXTRA_CXX_WARNINGS} -Wno-error=unused-lambda-capture")
endif() endif()

4
src/anbox/dbus/bus.cpp
View file

@ -20,9 +20,7 @@
namespace anbox { namespace anbox {
namespace dbus { namespace dbus {
Bus::Bus(Type type) : Bus::Bus(Type type) {
type_{type} {
int ret = 0; int ret = 0;
switch (type) { switch (type) {
case Type::Session: case Type::Session:

1
src/anbox/dbus/bus.h
View file

@ -48,7 +48,6 @@ class Bus : public DoNotCopyOrMove {
private: private:
void worker_main(); void worker_main();
Type type_;
sd_bus *bus_ = nullptr; sd_bus *bus_ = nullptr;
std::thread worker_thread_; std::thread worker_thread_;
std::atomic_bool running_{false}; std::atomic_bool running_{false};