From 7432fb15b3e6a6ca1bb5c05ea7ca4e0e81f9bbe0 Mon Sep 17 00:00:00 2001 From: Lee Jones Date: Wed, 3 May 2017 09:15:43 +0100 Subject: [PATCH 1/2] docs: build-android.md: Add missing step to initialise the build env Setting up the build environment is a required step. Without it, the subsequent step `lunch` will not be available. Signed-off-by: Lee Jones --- docs/build-android.md | 11 +++++++++-- 1 file changed, 9 insertions(+), 2 deletions(-) diff --git a/docs/build-android.md b/docs/build-android.md index 7f4b76e..3789155 100644 --- a/docs/build-android.md +++ b/docs/build-android.md @@ -33,8 +33,15 @@ This will take quite some time depending on the speed of your internet connectio ## Build Android -When all sources are successfully downloaded you can start building Android -itself. Initialize the build by +When all sources are successfully downloaded you can start building Android itself. + +Firstly initialize the environment with the ```envsetup.sh``` script. + +``` +$ . build/envsetup.sh +``` + +Then initialize the build using ```lunch```. ``` $ lunch anbox_desktop_x86_64-userdebug From 15067054c8657c8e4492518347d80107fd3cfe02 Mon Sep 17 00:00:00 2001 From: Lee Jones Date: Wed, 3 May 2017 16:30:44 +0100 Subject: [PATCH 2/2] rpc: connection_creator: Fix formatting error Warning currently prints out: [WW 2017-05-03 15:15:30] [connection_creator.cpp:47@create_connection_for] A second client tried to connect. Denied request as we already have oneand only allow a single client ^ Due to the way in which the code is formatted, we end up missing fudging the words 'one' and 'and'. Also the 3rd line in the source file seems somewhat superfluous. Let's fix that too. Signed-off-by: Lee Jones --- src/anbox/rpc/connection_creator.cpp | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/src/anbox/rpc/connection_creator.cpp b/src/anbox/rpc/connection_creator.cpp index 2989675..0ac1fd9 100644 --- a/src/anbox/rpc/connection_creator.cpp +++ b/src/anbox/rpc/connection_creator.cpp @@ -43,8 +43,7 @@ void ConnectionCreator::create_connection_for( socket->close(); WARNING( "A second client tried to connect. Denied request as we already have " - "one" - "and only allow a single client"); + "one and only allow a single client"); return; }