jyapayne/anbox
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

container: correctly calculate uid/gid maps

Browse source 
We were calculating the first range towards the ID of the executing user
which is wrong if we want to map the current user to id 1000 inside the
container. This corrects the code to calculate the first range until
1000-1, assigns 1000 to the current user and then continues to assign
1000+1 to the rest of the high-range ids we have allocated.
This commit is contained in:
Simon Fels 2018-08-08 21:00:58 +02:00
commit 82a1abc8cc
1 changed files with 2 additions and 2 deletions
Download patch file Download diff file Expand all files Collapse all files

4
src/anbox/container/lxc_container.cpp
View file

@ -80,8 +80,8 @@ void LxcContainer::setup_id_map() {
const auto base_id = unprivileged_uid;
const auto max_id = 65536;
set_config_item("lxc.idmap", utils::string_format("u 0 %d %d", base_id, creds_.uid() - 1));
set_config_item("lxc.idmap", utils::string_format("g 0 %d %d", base_id, creds_.gid() - 1));
set_config_item("lxc.idmap", utils::string_format("u 0 %d %d", base_id, android_system_uid - 1));
set_config_item("lxc.idmap", utils::string_format("g 0 %d %d", base_id, android_system_uid - 1));
// We need to bind the user id for the one running the client side
// process as he is the owner of various socket files we bind mount